cleanup

Author: systemallica

redsys/client.py

@@ -1,96 +1,98 @@
 # -*- coding: utf-8 -*-
-import sys
-import re
-import hashlib
-import json
 import base64
+import hashlib
 import hmac
-from Crypto.Cipher import DES3
+import json
+import re
+import sys
 from abc import ABCMeta, abstractmethod
-from . import currencies, languages, transactions
-from .response import Response
-from .request import Request
 
+from Crypto.Cipher import DES3
+
+from .request import Request
+from .response import Response
 
 # Calculated parameters
-SIGNATURE_VERSION = 'Ds_SignatureVersion'
-MERCHANT_PARAMETERS = 'Ds_MerchantParameters'
-SIGNATURE = 'Ds_Signature'
-DEFAULT_SIGNATURE_VERSION = 'HMAC_SHA256_V1'
+SIGNATURE_VERSION = "Ds_SignatureVersion"
+MERCHANT_PARAMETERS = "Ds_MerchantParameters"
+SIGNATURE = "Ds_Signature"
+DEFAULT_SIGNATURE_VERSION = "HMAC_SHA256_V1"
 
 
 class Client(object):
-
-    REAL_ENDPOINT = None
-    TEST_ENDPOINT = None
-
-    secret_key = None
-    endpoint = None
-
     __metaclass__ = ABCMeta
 
-    def __init__(self, secret_key, sandbox=False):
+    def __init__(self, secret_key=None, sandbox=False):
         self.secret_key = secret_key
         self.endpoint = self.TEST_ENDPOINT if sandbox else self.REAL_ENDPOINT
 
     def create_request(self):
         return Request()
 
     @abstractmethod
-    def create_response(self, signature, parameters, signature_version=DEFAULT_SIGNATURE_VERSION):
+    def create_response(
+        self, signature, parameters, signature_version=DEFAULT_SIGNATURE_VERSION
+    ):
         raise NotImplemented
 
     @abstractmethod
     def prepare_request(self, request):
         raise NotImplemented
 
     def encode_parameters(self, parameters):
-        return base64.b64encode(json.dumps(parameters).encode('utf-8'))
+        return base64.b64encode(json.dumps(parameters).encode("utf-8"))
 
     def decode_parameters(self, parameters):
-        return json.loads(base64.b64decode(parameters).decode('utf-8'))
+        return json.loads(base64.b64decode(parameters).decode("utf-8"))
 
     def encrypt_3DES(self, order):
-        pycrypto = DES3.new(base64.b64decode(self.secret_key), DES3.MODE_CBC, IV=b'\0\0\0\0\0\0\0\0')
-        if (sys.version_info > (3,0)):
-            order_padded = order.ljust(16, u'\x00')
+        pycrypto = DES3.new(
+            base64.b64decode(self.secret_key), DES3.MODE_CBC, IV=b"\0\0\0\0\0\0\0\0"
+        )
+        if sys.version_info > (3, 0):
+            order_padded = order.ljust(16, u"\x00")
         else:
-            order_padded = order.ljust(16, b'\0')
+            order_padded = order.ljust(16, b"\0")
 
         return pycrypto.encrypt(order_padded)
 
     def sign_hmac256(self, encrypted_order, merchant_parameters):
-        signature = hmac.new(encrypted_order, merchant_parameters, hashlib.sha256).digest()
+        signature = hmac.new(
+            encrypted_order, merchant_parameters, hashlib.sha256
+        ).digest()
         return base64.b64encode(signature)
 
     def generate_signature(self, order, merchant_parameters):
         return self.sign_hmac256(self.encrypt_3DES(order), merchant_parameters)
 
 
 class RedirectClient(Client):
-    REAL_ENDPOINT = u'https://sis.redsys.es/sis/realizarPago'
-    TEST_ENDPOINT = u'https://sis-t.redsys.es:25443/sis/realizarPago'
-
-    def create_response(self, signature, merchant_parameters, signature_version=DEFAULT_SIGNATURE_VERSION):
+    def create_response(
+        self,
+        signature,
+        merchant_parameters,
+        signature_version=DEFAULT_SIGNATURE_VERSION,
+    ):
         response = Response(self.decode_parameters(merchant_parameters))
-        calculated_signature = self.generate_signature(response.order, merchant_parameters.encode('utf-8'))
-        alphanum = re.compile('[^a-zA-Z0-9]')
-        safe_signature = re.sub(alphanum, '', signature)
-        safe_calculated_signature = re.sub(alphanum, '', calculated_signature.decode('utf-8'))
+        calculated_signature = self.generate_signature(
+            response.order, merchant_parameters.encode("utf-8")
+        )
+        alphanum = re.compile("[^a-zA-Z0-9]")
+        safe_signature = re.sub(alphanum, "", signature)
+        safe_calculated_signature = re.sub(
+            alphanum, "", calculated_signature.decode("utf-8")
+        )
         if safe_signature != safe_calculated_signature:
             raise ValueError("The provided signature is not valid.")
         return response
 
     def prepare_request(self, request):
         merchant_parameters = self.encode_parameters(request.prepare_parameters())
-        signature = self.sign_hmac256(self.encrypt_3DES(request.order), merchant_parameters)
+        signature = self.sign_hmac256(
+            self.encrypt_3DES(request.order), merchant_parameters
+        )
         return {
             SIGNATURE_VERSION: DEFAULT_SIGNATURE_VERSION,
             MERCHANT_PARAMETERS: merchant_parameters,
             SIGNATURE: signature,
         }
-
-
-class DirectClient(Client):
-    REAL_ENDPOINT = u'https://sis.redsys.es/sis/services/SerClsWSEntrada'
-    TEST_ENDPOINT = u'https://sis-t.redsys.es:25443/sis/services/SerClsWSEntrada'

redsys/currencies.py

@@ -45,20 +45,4 @@
 """ Turkish lira """
 TRY = 949
 
-CURRENCIES = [
-    EUR,
-    USD,
-    GBP,
-    JPY,
-    ARS,
-    CAD,
-    CLP,
-    COP,
-    INR,
-    MXN,
-    PEN,
-    CHF,
-    BRL,
-    VEF,
-    TRY
-]
+CURRENCIES = [EUR, USD, GBP, JPY, ARS, CAD, CLP, COP, INR, MXN, PEN, CHF, BRL, VEF, TRY]

redsys/languages.py

@@ -1,19 +1,19 @@
 # -*- coding: utf-8 -*-
 
-CUSTOMER = '000'
-SPANISH = '001'
-ENGLISH = '002'
-CATALAN = '003'
-FRENCH = '004'
-GERMAN = '005'
-DUTCH = '006'
-ITALIAN = '007'
-SWEDISH = '008'
-PORTUGUESE = '009'
-VALENCIAN = '010'
-POLISH = '011'
-GALICIAN = '012'
-EUSKERA = '013'
+CUSTOMER = "000"
+SPANISH = "001"
+ENGLISH = "002"
+CATALAN = "003"
+FRENCH = "004"
+GERMAN = "005"
+DUTCH = "006"
+ITALIAN = "007"
+SWEDISH = "008"
+PORTUGUESE = "009"
+VALENCIAN = "010"
+POLISH = "011"
+GALICIAN = "012"
+EUSKERA = "013"
 
 LANGUAGES = [
     CUSTOMER,
@@ -29,5 +29,5 @@
     VALENCIAN,
     POLISH,
     GALICIAN,
-    EUSKERA
+    EUSKERA,
 ]

redsys/request.py

@@ -1,64 +1,65 @@
 import re
 from decimal import Decimal
-from .transactions import TRANSACTION_TYPES
+
 from .currencies import CURRENCIES
 from .languages import LANGUAGES
+from .transactions import TRANSACTION_TYPES
 
 # General parameters
-MERCHANT_CODE = 'Ds_Merchant_MerchantCode'
-TERMINAL = 'Ds_Merchant_Terminal'
-TRANSACTION_TYPE = 'Ds_Merchant_TransactionType'
-ORDER = 'Ds_Merchant_Order'
-CURRENCY = 'Ds_Merchant_Currency'
-AMOUNT = 'Ds_Merchant_Amount'
+MERCHANT_CODE = "Ds_Merchant_MerchantCode"
+TERMINAL = "Ds_Merchant_Terminal"
+TRANSACTION_TYPE = "Ds_Merchant_TransactionType"
+ORDER = "Ds_Merchant_Order"
+CURRENCY = "Ds_Merchant_Currency"
+AMOUNT = "Ds_Merchant_Amount"
 
 # Recurring transaction parameters
-SUM_TOTAL = 'Ds_Merchant_SumTotal'
-DATE_FREQUENCY = 'Ds_Merchant_DateFrecuency'
-CHARGE_EXPIRY_DATE = 'Ds_Merchant_ChargeExpiryDate'
-TRANSACTION_DATE = 'Ds_Merchant_TransactionDate'
-AUTHORIZATION_CODE = 'Ds_Merchant_AuthorisationCode'
+SUM_TOTAL = "Ds_Merchant_SumTotal"
+DATE_FREQUENCY = "Ds_Merchant_DateFrecuency"
+CHARGE_EXPIRY_DATE = "Ds_Merchant_ChargeExpiryDate"
+TRANSACTION_DATE = "Ds_Merchant_TransactionDate"
+AUTHORIZATION_CODE = "Ds_Merchant_AuthorisationCode"
 
 # Not required parameters
-MERCHANT_DATA = 'Ds_Merchant_MerchantData'
+MERCHANT_DATA = "Ds_Merchant_MerchantData"
 
 # Redirect client paramenters
-MERCHANT_NAME = 'Ds_Merchant_MerchantName'
-PRODUCT_DESCRIPTION = 'Ds_Merchant_ProductDescription'
-TITULAR = 'Ds_Merchant_Titular'
-MERCHANT_URL = 'Ds_Merchant_MerchantURL'
-URL_OK = 'Ds_Merchant_UrlOK'
-URL_KO = 'Ds_Merchant_UrlKO'
-CONSUMER_LANGUAGE = 'Ds_Merchant_ConsumerLanguage'
+MERCHANT_NAME = "Ds_Merchant_MerchantName"
+PRODUCT_DESCRIPTION = "Ds_Merchant_ProductDescription"
+TITULAR = "Ds_Merchant_Titular"
+MERCHANT_URL = "Ds_Merchant_MerchantURL"
+URL_OK = "Ds_Merchant_UrlOK"
+URL_KO = "Ds_Merchant_UrlKO"
+CONSUMER_LANGUAGE = "Ds_Merchant_ConsumerLanguage"
 
 # Credit card data parameters
-PAN = 'Ds_Merchant_Pan'
-EXPIRY_DATE = 'Ds_Merchant_ExpiryDate'
-CVV2 = 'Ds_Merchant_Cvv2'
+PAN = "Ds_Merchant_Pan"
+EXPIRY_DATE = "Ds_Merchant_ExpiryDate"
+CVV2 = "Ds_Merchant_Cvv2"
 
 MERCHANT_PARAMETERS_MAP = {
-    'merchant_code': MERCHANT_CODE,
-    'terminal': TERMINAL,
-    'transaction_type': TRANSACTION_TYPE,
-    'order': ORDER,
-    'currency': CURRENCY,
-    'amount': AMOUNT,
-    'sum_total': SUM_TOTAL,
-    'date_frequency': DATE_FREQUENCY,
-    'charge_expiry_date': CHARGE_EXPIRY_DATE,
-    'transaction_date': TRANSACTION_DATE,
-    'authorization_code': AUTHORIZATION_CODE,
-    'merchant_data': MERCHANT_DATA,
-    'merchant_name': MERCHANT_NAME,
-    'product_description': PRODUCT_DESCRIPTION,
-    'titular': TITULAR,
-    'merchant_url': MERCHANT_URL,
-    'url_ok': URL_OK,
-    'url_ko': URL_KO,
-    'consumer_language': CONSUMER_LANGUAGE,
-    'pan': PAN,
-    'expiry_date': EXPIRY_DATE,
-    'cvv2': CVV2
+    "merchant_code": MERCHANT_CODE,
+    "terminal": TERMINAL,
+    "transaction_type": TRANSACTION_TYPE,
+    "order": ORDER,
+    "currency": CURRENCY,
+    "amount": AMOUNT,
+    "sum_total": SUM_TOTAL,
+    "date_frequency": DATE_FREQUENCY,
+    "charge_expiry_date": CHARGE_EXPIRY_DATE,
+    "transaction_date": TRANSACTION_DATE,
+    "authorization_code": AUTHORIZATION_CODE,
+    "merchant_data": MERCHANT_DATA,
+    "merchant_name": MERCHANT_NAME,
+    "product_description": PRODUCT_DESCRIPTION,
+    "titular": TITULAR,
+    "merchant_url": MERCHANT_URL,
+    "url_ok": URL_OK,
+    "url_ko": URL_KO,
+    "consumer_language": CONSUMER_LANGUAGE,
+    "pan": PAN,
+    "expiry_date": EXPIRY_DATE,
+    "cvv2": CVV2,
 }
 
 
@@ -67,6 +68,7 @@ class Request(object):
     Defines an atomic request with all the required parameters and sanitize
     their values according to the platform specifications
     """
+
     _parameters = {}
 
     def __getattr__(self, item):
@@ -84,7 +86,9 @@ def prepare_parameters(self):
         parameters = {}
         for key, value in self._parameters.items():
             prepare = getattr(self, "prepare_%s" % key, None)
-            parameters[MERCHANT_PARAMETERS_MAP[key]] = prepare(value) if prepare else value
+            parameters[MERCHANT_PARAMETERS_MAP[key]] = (
+                prepare(value) if prepare else value
+            )
         return parameters
 
     def prepare_amount(self, value):