Skip to content

Commit 897ee61

Browse files
committed
src/cachunk: use _cleanup_ in one more place
1 parent 98679b0 commit 897ee61

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/cachunk.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -686,7 +686,7 @@ int ca_chunk_file_save(
686686
const void *p,
687687
uint64_t l) {
688688

689-
char *suffix;
689+
_cleanup_free_ char *suffix = NULL;
690690
int fd, r;
691691

692692
if (chunk_fd < 0 && chunk_fd != AT_FDCWD)
@@ -718,10 +718,8 @@ int ca_chunk_file_save(
718718
return -ENOMEM;
719719

720720
fd = ca_chunk_file_open(chunk_fd, prefix, chunkid, suffix, O_WRONLY|O_CREAT|O_EXCL|O_NOCTTY|O_CLOEXEC);
721-
if (fd < 0) {
722-
free(suffix);
721+
if (fd < 0)
723722
return fd;
724-
}
725723

726724
if (desired_compression == CA_CHUNK_AS_IS)
727725
desired_compression = effective_compression;
@@ -742,12 +740,10 @@ int ca_chunk_file_save(
742740
if (r < 0)
743741
goto fail;
744742

745-
free(suffix);
746743
return 0;
747744

748745
fail:
749746
(void) ca_chunk_file_unlink(chunk_fd, prefix, chunkid, suffix);
750-
free(suffix);
751747
return r;
752748
}
753749

0 commit comments

Comments
 (0)