Skip to content

Commit 3f1dccd

Browse files
committed
use fstat(), include filename in error messages.
1 parent 2c8198c commit 3f1dccd

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/store.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,10 @@ static int proc_read_full_file(int procfd, const char *fn, char **contents, size
130130

131131
fd = openat(procfd, fn, O_RDONLY|O_CLOEXEC);
132132
if (fd < 0)
133-
return log_error_errno(errno, "Failed to openat /proc/<>: %m");
133+
return log_error_errno(errno, "Failed to openat /proc/%s: %m", fn);
134134

135-
if (fstatat(procfd, fn, &st, 0) < 0)
136-
return log_error_errno(errno, "Failed to fstatat /proc/<>: %m");
135+
if (fstat(fd, &st) < 0)
136+
return log_error_errno(errno, "Failed to fstat /proc/%s: %m", fn);
137137

138138
n = LINE_MAX;
139139
if (S_ISREG(st.st_mode)) {
@@ -162,7 +162,7 @@ static int proc_read_full_file(int procfd, const char *fn, char **contents, size
162162
k = pread(fd, buf + l, n - l, l);
163163

164164
if (k < 0)
165-
return log_error_errno(errno, "Failed to pread /proc/<>: %m");
165+
return log_error_errno(errno, "Failed to pread /proc/%s: %m", fn);
166166
if (k == 0)
167167
break;
168168

0 commit comments

Comments
 (0)