Skip to content

Commit 83ed448

Browse files
committed
Warn on suspicious configuration settings
1 parent 453ce7a commit 83ed448

File tree

1 file changed

+23
-0
lines changed

1 file changed

+23
-0
lines changed

src/netlog/netlog-conf.c

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,5 +216,28 @@ int manager_parse_config_file(Manager *m) {
216216
m->connection_retry_usec = DEFAULT_CONNECTION_RETRY_USEC;
217217
}
218218

219+
if (m->auth_mode != OPEN_SSL_CERTIFICATE_AUTH_MODE_NONE
220+
&& m->protocol != SYSLOG_TRANSMISSION_PROTOCOL_TLS
221+
&& m->protocol != SYSLOG_TRANSMISSION_PROTOCOL_DTLS)
222+
log_warning("TLSCertificateAuthMode= set but unencrypted %s connection specified.", protocol_to_string(m->protocol));
223+
224+
if (m->dir && m->namespace)
225+
log_warning("Ignoring Namespace= setting since Directory= is set.");
226+
227+
if (m->structured_data && m->syslog_structured_data)
228+
log_warning("Ignoring UseSysLogStructuredData= since StructuredData= is set.");
229+
230+
if (timestamp_is_set(m->keep_alive_time) && !m->keep_alive)
231+
log_warning("Ignoring KeepAliveTimeSec= since KeepAlive= is not set.");
232+
233+
if (m->keep_alive_interval > 0 && !m->keep_alive)
234+
log_warning("Ignoring KeepAliveIntervalSec= since KeepAlive= is not set.");
235+
236+
if (m->keep_alive_cnt > 0 && !m->keep_alive)
237+
log_warning("Ignoring KeepAliveProbes= since KeepAlive= is not set.");
238+
239+
if (m->send_buffer != 0 && (m->send_buffer < 4096 || m->send_buffer > 128 * 1024 * 1024))
240+
log_warning("SendBuffer= set to an suspicious value of %zu.", m->send_buffer);
241+
219242
return 0;
220243
}

0 commit comments

Comments
 (0)