Skip to content

Commit 668880c

Browse files
mrc0mmandbluca
authored andcommitted
test: don't store udev worker coredumps in journal
udev before #30532 may kill the worker process together with a slow program, and when running with sanitizers the resulting coredump might be too big to fit into journal (or the space currently available for journal): [ 30.086194] systemd-journald[330]: Failed to write entry to /var/log/journal/e87de9ccbacf4b88924ff6d9ecaaa82d/system.journal (50 items, 68326399 bytes) despite vacuuming, ignoring: Argument list too long This then makes the test fail, as it checks for the presence of the coredump. Since we don't really care about the coredump in this specific case (as it is an expected one), let's just temporarily override the testsuite-wide Storage=journal and store the coredumps externally. This is a v255-stable-only patch, since after #30532 the test no longer checks for coredumps. (cherry picked from commit 27fc7a0)
1 parent 3253db0 commit 668880c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

test/units/testsuite-17.03.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ KILL_PID=
88
setup() {
99
mkdir -p "${TEST_RULE%/*}"
1010
[[ -e /etc/udev/udev.conf ]] && cp -f /etc/udev/udev.conf /etc/udev/udev.conf.bak
11+
# Don't bother storing the coredumps in journal for this particular test
12+
mkdir -p /run/systemd/coredump.conf.d/
13+
echo -ne "[Coredump]\nStorage=external\n" >/run/systemd/coredump.conf.d/99-storage-journal.conf
1114

1215
cat >"${TEST_RULE}" <<EOF
1316
ACTION=="add", SUBSYSTEM=="mem", KERNEL=="null", OPTIONS="log_level=debug"
@@ -32,6 +35,7 @@ teardown() {
3235
rm -rf "$TMPDIR"
3336
rm -f "$TEST_RULE"
3437
[[ -e /etc/udev/udev.conf.bak ]] && mv -f /etc/udev/udev.conf.bak /etc/udev/udev.conf
38+
rm /run/systemd/coredump.conf.d/99-storage-journal.conf
3539
systemctl restart systemd-udevd.service
3640
}
3741

0 commit comments

Comments
 (0)