Skip to content

Commit ad54019

Browse files
DaanDeMeyerbluca
authored andcommitted
tree-wide: Always include <net/if.h> before related linux headers
Otherwise, we get redefinition errors if <net/if.h> is included later on by another header. (cherry picked from commit 2af02e6) (cherry picked from commit 49a3ecd) (cherry picked from commit 299e6cd)
1 parent bd7859a commit ad54019

File tree

6 files changed

+14
-8
lines changed

6 files changed

+14
-8
lines changed

src/libsystemd-network/sd-dhcp6-client.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55

66
#include <errno.h>
77
#include <sys/ioctl.h>
8-
#include <linux/if_arp.h>
9-
#include <linux/if_infiniband.h>
8+
#include <net/if.h>
9+
#include <linux/if_arp.h> /* Must be included after <net/if.h> */
10+
#include <linux/if_infiniband.h> /* Must be included after <net/if.h> */
1011

1112
#include "sd-dhcp6-client.h"
1213

src/network/networkd-dhcp-server.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
/* SPDX-License-Identifier: LGPL-2.1-or-later */
22

33
#include <netinet/in.h>
4-
#include <linux/if_arp.h>
5-
#include <linux/if.h>
4+
#include <net/if.h>
5+
#include <linux/if_arp.h> /* Must be included after <net/if.h> */
6+
#include <linux/if.h> /* Must be included after <net/if.h> */
67

78
#include "sd-dhcp-server.h"
89

src/network/networkd-manager.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
#include <netinet/in.h>
44
#include <sys/socket.h>
55
#include <unistd.h>
6-
#include <linux/if.h>
6+
#include <net/if.h>
7+
#include <linux/if.h> /* Must be included after <net/if.h> */
78
#include <linux/fib_rules.h>
89
#include <linux/nexthop.h>
910
#include <linux/nl80211.h>

src/network/networkd-state-file.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
/* SPDX-License-Identifier: LGPL-2.1-or-later */
22

33
#include <netinet/in.h>
4-
#include <linux/if.h>
4+
#include <net/if.h>
5+
#include <linux/if.h> /* Must be included after <net/if.h> */
56

67
#include "alloc-util.h"
78
#include "dns-domain.h"

src/resolve/resolved-link.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
/* SPDX-License-Identifier: LGPL-2.1-or-later */
22

3-
#include <linux/if.h>
3+
#include <net/if.h>
4+
#include <linux/if.h> /* Must be included after <net/if.h> */
45
#include <unistd.h>
56

67
#include "sd-network.h"

src/udev/net/link-config.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
/* SPDX-License-Identifier: LGPL-2.1-or-later */
22

3-
#include <linux/netdevice.h>
3+
#include <net/if.h>
4+
#include <linux/netdevice.h> /* Must be included after <net/if.h> */
45
#include <netinet/ether.h>
56
#include <unistd.h>
67

0 commit comments

Comments
 (0)