Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

Commit 3a270df

Browse files
committed
fix(dal): import func arguments during module update and fix PropPath conversion
1 parent f1a4737 commit 3a270df

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

lib/dal/src/pkg/import.rs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,7 @@ pub async fn import_funcs_for_module_update(
591591
}
592592
}
593593

594-
import_func(
594+
let func = import_func(
595595
ctx,
596596
&func_spec,
597597
None,
@@ -600,6 +600,11 @@ pub async fn import_funcs_for_module_update(
600600
super::UpdateMode::UpdateExisting,
601601
)
602602
.await?;
603+
604+
let args: Vec<_> = func_spec.arguments()?.into_iter().collect();
605+
if !args.is_empty() {
606+
import_func_arguments(ctx, func.id, &args).await?;
607+
}
603608
}
604609

605610
Ok(thing_map)
@@ -1782,8 +1787,11 @@ async fn create_attr_proto_arg(
17821787

17831788
Ok(match input {
17841789
SiPkgAttrFuncInputView::Prop { prop_path, .. } => {
1790+
// Convert slash-separated path like "/root/domain/extra" to PropPath
1791+
let path_parts: Vec<&str> = prop_path.split('/').filter(|s| !s.is_empty()).collect();
17851792
let prop_id =
1786-
Prop::find_prop_id_by_path(ctx, schema_variant_id, &prop_path.into()).await?;
1793+
Prop::find_prop_id_by_path(ctx, schema_variant_id, &PropPath::new(path_parts))
1794+
.await?;
17871795
AttributePrototypeArgument::new(ctx, prototype_id, arg.id, prop_id).await?
17881796
}
17891797
SiPkgAttrFuncInputView::InputSocket { socket_name, .. } => {

0 commit comments

Comments
 (0)