fix: support ints within schema for AWS::EC2::AutoscalingGroup

Author: johnrwatson

bin/clover/src/pipelines/aws/funcs/overrides/AWS::AutoScaling::AutoScalingGroup/actions/awsCloudControlUpdate.ts

@@ -78,18 +78,6 @@ async function main(component: Input): Promise<Output> {
     resourceResponse["ResourceDescription"]["Properties"],
   );
 
-  // Convert string properties that should be integers to numbers
-  const integerProps = ["MaxSize", "MinSize", "Cooldown", "DesiredCapacity"];
-  integerProps.forEach(propName => {
-    if (currentState[propName] && typeof currentState[propName] === "string") {
-      const numValue = parseInt(currentState[propName], 10);
-      if (!isNaN(numValue)) {
-        currentState[propName] = numValue;
-        console.log(`[ASG-UPDATE] Converted currentState.${propName} from "${currentState[propName]}" to ${numValue}`);
-      }
-    }
-  });
-
   const desiredProps = JSON.parse(
     component.properties.code?.["awsCloudControlUpdate"]?.code,
   )?.DesiredState;
@@ -101,27 +89,31 @@ async function main(component: Input): Promise<Output> {
 
   addSecretsToPayload(desiredProps, propUsageMap);
 
-  // Also convert integer properties in desiredProps to ensure consistency
+  // Keep patch operations using strings to match AWS CloudControl expectations
+  // Convert integer properties in desiredProps to strings if AWS returns strings
+  const integerProps = ["MaxSize", "MinSize", "Cooldown", "DesiredCapacity"];
   integerProps.forEach(propName => {
-    if (desiredProps[propName] && typeof desiredProps[propName] === "string") {
-      const numValue = parseInt(desiredProps[propName], 10);
-      if (!isNaN(numValue)) {
-        desiredProps[propName] = numValue;
-        console.log(`[ASG-UPDATE] Converted desiredProps.${propName} from "${desiredProps[propName]}" to ${numValue}`);
+    if (desiredProps[propName] !== undefined) {
+      // If AWS returns string and desired is number, convert desired to string for patch
+      if (typeof currentState[propName] === "string" && typeof desiredProps[propName] === "number") {
+        desiredProps[propName] = String(desiredProps[propName]);
+        console.log(`[ASG-UPDATE] Converted desiredProps.${propName} to string "${desiredProps[propName]}" to match AWS format`);
       }
+      // If AWS returns string and desired is string, keep as string
+      // If both are numbers, keep as numbers
     }
   });
 
   const desiredState = _.cloneDeep(currentState);
   _.merge(desiredState, desiredProps);
 
-  console.log(`[ASG-UPDATE] Debug - currentState integer props:`, {
+  console.log(`[ASG-UPDATE] Debug - patch will use currentState types:`, {
     MaxSize: currentState.MaxSize, 
     MinSize: currentState.MinSize, 
     Cooldown: currentState.Cooldown, 
     DesiredCapacity: currentState.DesiredCapacity
   });
-  console.log(`[ASG-UPDATE] Debug - desiredState integer props:`, {
+  console.log(`[ASG-UPDATE] Debug - patch will use desiredState types:`, {
     MaxSize: desiredState.MaxSize, 
     MinSize: desiredState.MinSize, 
     Cooldown: desiredState.Cooldown, 
@@ -389,7 +381,8 @@ async function main(component: Input): Promise<Output> {
       finalResourceResponse["ResourceDescription"]["Properties"],
     );
 
-    // Convert string properties that should be integers to numbers
+    // Convert string properties that should be integers to numbers for final payload
+    const integerProps = ["MaxSize", "MinSize", "Cooldown", "DesiredCapacity"];
     integerProps.forEach(propName => {
       if (payload[propName] && typeof payload[propName] === "string") {
         const numValue = parseInt(payload[propName], 10);