Merge pull request #59 from systemli/Update-error-handling-in-Userli-methods

🐛 Update error handling in Userli methods

Author: 0x46616c6b

userli.go

@@ -131,7 +131,7 @@ func (u *Userli) GetAliases(ctx context.Context, email string) ([]string, error)
 	sanitizedEmail, err := u.sanitizeEmail(email)
 	if err != nil {
 		log.WithError(err).WithField("email", email).Info("unable to process the alias")
-		return []string{}, err
+		return []string{}, nil
 	}
 
 	resp, err := u.call(ctx, fmt.Sprintf("%s/api/postfix/alias/%s", u.baseURL, sanitizedEmail))
@@ -170,7 +170,7 @@ func (u *Userli) GetMailbox(ctx context.Context, email string) (bool, error) {
 	sanitizedEmail, err := u.sanitizeEmail(email)
 	if err != nil {
 		log.WithError(err).WithField("email", email).Info("unable to process the mailbox")
-		return false, err
+		return false, nil
 	}
 
 	resp, err := u.call(ctx, fmt.Sprintf("%s/api/postfix/mailbox/%s", u.baseURL, sanitizedEmail))
@@ -192,7 +192,7 @@ func (u *Userli) GetSenders(ctx context.Context, email string) ([]string, error)
 	sanitizedEmail, err := u.sanitizeEmail(email)
 	if err != nil {
 		log.WithError(err).WithField("email", email).Info("unable to process the senders")
-		return []string{}, err
+		return []string{}, nil
 	}
 
 	resp, err := u.call(ctx, fmt.Sprintf("%s/api/postfix/senders/%s", u.baseURL, sanitizedEmail))

userli_test.go

@@ -45,7 +45,7 @@ func (s *UserliTestSuite) TestGetAliases() {
 
 	s.Run("no email", func() {
 		aliases, err := s.userli.GetAliases(context.Background(), "alias")
-		s.Error(err)
+		s.NoError(err)
 		s.Empty(aliases)
 	})
 
@@ -134,7 +134,7 @@ func (s *UserliTestSuite) TestGetMailbox() {
 
 	s.Run("no email", func() {
 		active, err := s.userli.GetMailbox(context.Background(), "user")
-		s.Error(err)
+		s.NoError(err)
 		s.False(active)
 	})
 
@@ -190,7 +190,7 @@ func (s *UserliTestSuite) TestGetSenders() {
 
 	s.Run("no email", func() {
 		senders, err := s.userli.GetSenders(context.Background(), "user")
-		s.Error(err)
+		s.NoError(err)
 		s.Empty(senders)
 	})