Skip to content

Commit 15bd3ae

Browse files
Xunzhuoszedan-rh
authored andcommitted
fix(helm): remove namespace template to resolve installation conflicts (vllm-project#651)
* fix(helm): remove namespace template to resolve installation conflicts The namespace.yaml template with lookup function causes installation failures when the namespace already exists. Removing this template allows Helm's --create-namespace flag to handle namespace creation properly, avoiding conflicts with existing namespaces. Fixes the error: namespaces "vllm-semantic-router-system" already exists Signed-off-by: bitliu <[email protected]> * fix(ci): update helm-ci workflow to remove namespace check Remove Namespace from required resources check since namespace.yaml template has been removed. The namespace is now managed by Helm's --create-namespace flag instead of being part of the chart templates. Signed-off-by: bitliu <[email protected]> * fix(ci): update validate-chart.sh to remove namespace checks Remove namespace.yaml from required files list and Namespace from required resources check in the validation script. The namespace is now managed by Helm's --create-namespace flag. Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]>
1 parent 4c23e97 commit 15bd3ae

File tree

3 files changed

+2
-11
lines changed

3 files changed

+2
-11
lines changed

.github/workflows/helm-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ jobs:
111111
run: |
112112
echo "::group::Verify Required Resources"
113113
required_resources=(
114-
"Namespace"
115114
"ServiceAccount"
116115
"PersistentVolumeClaim"
117116
"ConfigMap"
@@ -128,6 +127,7 @@ jobs:
128127
fi
129128
done
130129
echo "All required resources found"
130+
echo "Note: Namespace is managed by Helm's --create-namespace flag"
131131
echo "::endgroup::"
132132
133133
- name: Upload templates as artifacts

deploy/helm/semantic-router/templates/namespace.yaml

Lines changed: 0 additions & 8 deletions
This file was deleted.

deploy/helm/validate-chart.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ required_files=(
119119
"templates/deployment.yaml"
120120
"templates/service.yaml"
121121
"templates/configmap.yaml"
122-
"templates/namespace.yaml"
123122
"templates/pvc.yaml"
124123
"templates/serviceaccount.yaml"
125124
"templates/ingress.yaml"
@@ -146,7 +145,6 @@ echo ""
146145
# Test 7: Validate generated resources
147146
log_info "Validating generated Kubernetes resources..."
148147
resource_types=(
149-
"Namespace"
150148
"ServiceAccount"
151149
"PersistentVolumeClaim"
152150
"ConfigMap"
@@ -162,6 +160,7 @@ for resource in "${resource_types[@]}"; do
162160
exit 1
163161
fi
164162
done
163+
log_info "Note: Namespace is managed by Helm's --create-namespace flag"
165164
echo ""
166165

167166
# Test 8: Validate Chart.yaml

0 commit comments

Comments
 (0)