Commit 15bd3ae
fix(helm): remove namespace template to resolve installation conflicts (vllm-project#651)
* fix(helm): remove namespace template to resolve installation conflicts
The namespace.yaml template with lookup function causes installation
failures when the namespace already exists. Removing this template
allows Helm's --create-namespace flag to handle namespace creation
properly, avoiding conflicts with existing namespaces.
Fixes the error: namespaces "vllm-semantic-router-system" already exists
Signed-off-by: bitliu <[email protected]>
* fix(ci): update helm-ci workflow to remove namespace check
Remove Namespace from required resources check since namespace.yaml
template has been removed. The namespace is now managed by Helm's
--create-namespace flag instead of being part of the chart templates.
Signed-off-by: bitliu <[email protected]>
* fix(ci): update validate-chart.sh to remove namespace checks
Remove namespace.yaml from required files list and Namespace from
required resources check in the validation script. The namespace
is now managed by Helm's --create-namespace flag.
Signed-off-by: bitliu <[email protected]>
---------
Signed-off-by: bitliu <[email protected]>1 parent 4c23e97 commit 15bd3ae
File tree
3 files changed
+2
-11
lines changed- .github/workflows
- deploy/helm
- semantic-router/templates
3 files changed
+2
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
115 | 114 | | |
116 | 115 | | |
117 | 116 | | |
| |||
128 | 127 | | |
129 | 128 | | |
130 | 129 | | |
| 130 | + | |
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
123 | 122 | | |
124 | 123 | | |
125 | 124 | | |
| |||
146 | 145 | | |
147 | 146 | | |
148 | 147 | | |
149 | | - | |
150 | 148 | | |
151 | 149 | | |
152 | 150 | | |
| |||
162 | 160 | | |
163 | 161 | | |
164 | 162 | | |
| 163 | + | |
165 | 164 | | |
166 | 165 | | |
167 | 166 | | |
| |||
0 commit comments