From 7a289c83240d7e46a997254ed3c4c8a22770ca93 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Viktor=20Sz=C3=A9pe?= <viktor@szepe.net>
Date: Thu, 28 Mar 2024 02:29:52 +0100
Subject: [PATCH 1/2] Do not use superglobals

---
 PSR12NeutronRuleset/ruleset.xml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/PSR12NeutronRuleset/ruleset.xml b/PSR12NeutronRuleset/ruleset.xml
index 1966d17..33a4107 100644
--- a/PSR12NeutronRuleset/ruleset.xml
+++ b/PSR12NeutronRuleset/ruleset.xml
@@ -312,6 +312,15 @@
                 <element key="value" value="Provide more context"/>
                 <element key="var" value="Provide more context"/>
                 <element key="vdata" value="Provide more context"/>
+                <element key="GLOBALS" value="Do not use superglobals"/>
+                <element key="_SERVER" value="Do not use superglobals"/>
+                <element key="_GET" value="Do not use superglobals"/>
+                <element key="_POST" value="Do not use superglobals"/>
+                <element key="_FILES" value="Do not use superglobals"/>
+                <element key="_COOKIE" value="Do not use superglobals"/>
+                <element key="_SESSION" value="Do not use superglobals"/>
+                <element key="_REQUEST" value="Do not use superglobals"/>
+                <element key="_ENV" value="Do not use superglobals"/>
             </property>
         </properties>
     </rule>

From 0549b1705ba3c8d4ec50ec31a3b5a5231b5941a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Viktor=20Sz=C3=A9pe?= <viktor@szepe.net>
Date: Thu, 28 Mar 2024 02:32:05 +0100
Subject: [PATCH 2/2] fix comments

---
 PSR12NeutronRuleset/ruleset.xml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/PSR12NeutronRuleset/ruleset.xml b/PSR12NeutronRuleset/ruleset.xml
index 33a4107..2478304 100644
--- a/PSR12NeutronRuleset/ruleset.xml
+++ b/PSR12NeutronRuleset/ruleset.xml
@@ -274,10 +274,10 @@
         <severity>5</severity>
         <type>warning</type>
     </rule>
-    <!-- https://github.com/szepeviktor/uninformative-words -->
     <rule ref="PSR12NeutronRuleset.NamingConventions.MeaningfulVariableName">
         <properties>
             <property name="forbiddenNames" type="array">
+                <!-- https://github.com/szepeviktor/uninformative-words -->
                 <element key="arr" value="Provide more context"/>
                 <element key="bool" value="Provide more context"/>
                 <element key="boolean" value="Provide more context"/>
@@ -312,6 +312,7 @@
                 <element key="value" value="Provide more context"/>
                 <element key="var" value="Provide more context"/>
                 <element key="vdata" value="Provide more context"/>
+                <!-- https://www.php.net/manual/en/language.variables.superglobals.php -->
                 <element key="GLOBALS" value="Do not use superglobals"/>
                 <element key="_SERVER" value="Do not use superglobals"/>
                 <element key="_GET" value="Do not use superglobals"/>