Improvements

Author: szepeviktor

tiny-cache.php

@@ -45,7 +45,7 @@ function the_content_cached( $more_link_text = null, $strip_teaser = false ) {
         return;
     }
 
-    $found  = null;
+    $found  = false;
     $cached = wp_cache_get( $post_id, 'the_content', false, $found );
 
     // Cache hit.
@@ -169,7 +169,7 @@ function get_template_part_cached( $slug, $name = null, $version_hash = '' ) {
     }
     $key = sprintf( '%s%s:%s', $slug, $file_suffix, $version_hash );
 
-    $found  = null;
+    $found  = false;
     $cached = wp_cache_get( $key, 'template_part', false, $found );
 
     // Cache hit.

tiny-nav-menu-cache.php

@@ -2,7 +2,7 @@
 /**
  * Plugin Name: Tiny navigation menu cache (MU)
  * Description: Cache nav menu's HTML content in persistent object cache.
- * Version:     0.2.0
+ * Version:     0.2.1
  * Constants:   TINY_CACHE_NAV_MENU_EXCLUDES
  */
 
@@ -67,8 +67,7 @@ public function init() {
      */
     public function get_nav_menu( $nav_menu_html, $args ) {
 
-        $enabled = $this->is_enabled( $args );
-        if ( $enabled ) {
+        if ( $this->is_enabled( $args ) ) {
             $found = null;
             $cache = wp_cache_get( $this->get_cache_key( $args ), self::GROUP, false, $found );
             if ( $found ) {
@@ -87,8 +86,7 @@ public function get_nav_menu( $nav_menu_html, $args ) {
      */
     public function save_nav_menu( $nav_menu_html, $args ) {
 
-        $enabled = $this->is_enabled( $args );
-        if ( $enabled ) {
+        if ( $this->is_enabled( $args ) ) {
             $key = $this->get_cache_key( $args );
             wp_cache_set( $key, $nav_menu_html, self::GROUP, DAY_IN_SECONDS );
             $this->remember_key( $key );
@@ -111,13 +109,10 @@ public function flush_all() {
     private function remember_key( $key ) {
 
         // @TODO Not atomic
-        $found    = null;
+        $found    = false;
         $key_list = wp_cache_get( 'key_list', self::GROUP, false, $found );
-        if ( $found ) {
-            $key_list .= '|' . $key;
-        } else {
-            $key_list = $key;
-        }
+
+        $key_list = $found ? $key_list . '|' . $key : $key;
         wp_cache_set( 'key_list', $key_list, self::GROUP, DAY_IN_SECONDS );
     }