Fix request abort check on Node.js 13

Author: szmarczak

package.json

@@ -59,6 +59,9 @@
 	"nyc": {
 		"extension": [
 			".ts"
+		],
+		"exclude": [
+			"**/tests/**"
 		]
 	},
 	"ava": {

source/index.ts

@@ -34,6 +34,8 @@ export interface IncomingMessageWithTimings extends IncomingMessage {
 	timings?: Timings;
 }
 
+const nodejsMajorVersion = Number(process.versions.node.split('.')[0]);
+
 const timer = (request: ClientRequestWithTimings): Timings => {
 	const timings: Timings = {
 		start: Date.now(),
@@ -81,8 +83,9 @@ const timer = (request: ClientRequestWithTimings): Timings => {
 	request.prependOnceListener('abort', (): void => {
 		timings.abort = Date.now();
 
-		// Let the `end` response event be responsible for setting the total phase
-		if (!timings.response) {
+		// Let the `end` response event be responsible for setting the total phase,
+		// unless the Node.js major version is >= 13.
+		if (!timings.response || nodejsMajorVersion >= 13) {
 			timings.phases.total = Date.now() - timings.start;
 		}
 	});

tests/test.ts

@@ -32,6 +32,8 @@ test.after('cleanup', async () => {
 	await server.closeAsync();
 });
 
+const nodejsMajorVersion = Number(process.versions.node.split('.')[0]);
+
 const error = 'Simple error';
 
 const makeRequest = (url = 'https://httpbin.org/anything', options: http.RequestOptions = {agent: false}): {request: ClientRequest; timings: Timings} => {
@@ -205,13 +207,23 @@ test.cb('sets `total` on abort - after `response` event', t => {
 	request.once('response', response => {
 		request.abort();
 
-		response.once('end', () => {
-			t.is(typeof timings.abort, 'number');
-			t.is(timings.phases.total, timings.end! - timings.start);
-			t.truthy((request as any).res);
-
-			t.end();
-		});
+		if (nodejsMajorVersion >= 13) {
+			process.nextTick(() => {
+				t.is(typeof timings.abort, 'number');
+				t.is(timings.phases.total, timings.abort! - timings.start);
+				t.truthy((request as any).res);
+
+				t.end();
+			});
+		} else {
+			response.once('end', () => {
+				t.is(typeof timings.abort, 'number');
+				t.is(timings.phases.total, timings.end! - timings.start);
+				t.truthy((request as any).res);
+
+				t.end();
+			});
+		}
 	});
 });