Merge pull request #672 from t1m0thyj/feat/replace-wpf-with-skia

Use SkiaSharp instead of WPF to render theme previews

Author: t1m0thyj

.github/workflows/codeql.yml

@@ -30,10 +30,16 @@ jobs:
     - name: Checkout repository
       uses: actions/checkout@v6
 
+    - name: Setup .NET
+      uses: actions/setup-dotnet@v5
+      with:
+        dotnet-version: 10.0.x
+
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v4
       with:
         languages: ${{ matrix.language }}
+        queries: +security-extended
 
     - name: Autobuild
       run: |

src/COM/DesktopWallpaper.cs

@@ -16,6 +16,15 @@ public struct COLORREF
         public byte B;
     }
 
+    [StructLayout(LayoutKind.Sequential)]
+    public struct RECT
+    {
+        public int Left;
+        public int Top;
+        public int Right;
+        public int Bottom;
+    }
+
     public enum DesktopSlideshowOptions
     {
         DSO_SHUFFLEIMAGES = 0x01,
@@ -59,7 +68,7 @@ public interface IDesktopWallpaper
 
         uint GetMonitorDevicePathCount();
 
-        System.Windows.Rect GetMonitorRECT([MarshalAs(UnmanagedType.LPWStr)] string monitorID);
+        RECT GetMonitorRECT([MarshalAs(UnmanagedType.LPWStr)] string monitorID);
 
         void SetBackgroundColor([MarshalAs(UnmanagedType.U4)] COLORREF color);
 

src/Skia/ImageCache.cs

@@ -0,0 +1,160 @@
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Reflection;
+using System.Windows.Forms;
+using SkiaSharp;
+
+namespace WinDynamicDesktop.Skia
+{
+    sealed class ImageCache
+    {
+        readonly int maxWidth;
+        readonly int maxHeight;
+        readonly object cacheLock = new object();
+        readonly Dictionary<Uri, SKImage> images = new Dictionary<Uri, SKImage>();
+
+        public SKImage this[Uri uri]
+        {
+            get
+            {
+                lock (cacheLock)
+                {
+                    if (images.TryGetValue(uri, out var image))
+                    {
+                        return image;
+                    }
+
+                    var img = CreateImage(uri);
+                    if (img != null)
+                    {
+                        images.Add(uri, img);
+                    }
+                    return img;
+                }
+            }
+        }
+
+        public void Clear()
+        {
+            lock (cacheLock)
+            {
+                foreach (var image in images.Values)
+                {
+                    image?.Dispose();
+                }
+                images.Clear();
+            }
+            GC.Collect();
+        }
+
+        public ImageCache(bool limitDecodeSize = true)
+        {
+            if (limitDecodeSize)
+            {
+                int maxArea = 0;
+                foreach (Screen screen in Screen.AllScreens)
+                {
+                    int area = screen.Bounds.Width * screen.Bounds.Height;
+                    if (area > maxArea)
+                    {
+                        maxArea = area;
+                        maxWidth = screen.Bounds.Width;
+                        maxHeight = screen.Bounds.Height;
+                    }
+                }
+            }
+            else
+            {
+                maxWidth = int.MaxValue;
+                maxHeight = int.MaxValue;
+            }
+        }
+
+        private SKImage CreateImage(Uri uri)
+        {
+            try
+            {
+                Stream stream = null;
+
+                if (uri.IsAbsoluteUri && uri.Scheme == "file")
+                {
+                    string path = uri.LocalPath;
+                    if (File.Exists(path))
+                    {
+                        stream = File.OpenRead(path);
+                    }
+                }
+                else if (!uri.IsAbsoluteUri)
+                {
+                    // Embedded resource
+                    stream = Assembly.GetExecutingAssembly().GetManifestResourceStream(uri.OriginalString);
+                }
+
+                if (stream == null)
+                {
+                    return null;
+                }
+
+                using (stream)
+                {
+                    using (var codec = SKCodec.Create(stream))
+                    {
+                        if (codec == null)
+                        {
+                            return null;
+                        }
+
+                        var info = codec.Info;
+                        
+                        // Calculate target dimensions
+                        int targetWidth = info.Width;
+                        int targetHeight = info.Height;
+
+                        if (info.Width > maxWidth || info.Height > maxHeight)
+                        {
+                            float scale = Math.Min((float)maxWidth / info.Width, (float)maxHeight / info.Height);
+                            targetWidth = (int)(info.Width * scale);
+                            targetHeight = (int)(info.Height * scale);
+                        }
+
+                        // Decode at native size
+                        using (var sourceBitmap = new SKBitmap(info))
+                        {
+                            if (codec.GetPixels(sourceBitmap.Info, sourceBitmap.GetPixels()) != SKCodecResult.Success)
+                            {
+                                return null;
+                            }
+
+                            // If scaling is needed, create scaled version with high quality
+                            if (targetWidth != sourceBitmap.Width || targetHeight != sourceBitmap.Height)
+                            {
+                                using (var scaledBitmap = new SKBitmap(targetWidth, targetHeight, info.ColorType, info.AlphaType))
+                                {
+                                    sourceBitmap.ScalePixels(scaledBitmap, new SKSamplingOptions(SKCubicResampler.Mitchell));
+                                    var image = SKImage.FromBitmap(scaledBitmap);
+                                    return image;
+                                }
+                            }
+                            else
+                            {
+                                // No scaling needed
+                                var image = SKImage.FromBitmap(sourceBitmap);
+                                return image;
+                            }
+                        }
+                    }
+                }
+            }
+            catch
+            {
+                return null;
+            }
+        }
+    }
+}