Add hidden form to receive application restart events

Author: t1m0thyj

scripts/installer.iss

@@ -35,6 +35,7 @@ WizardStyle=modern
 CloseApplications=force
 LicenseFile=..\LICENSE
 OutputDir=..\dist
+RestartApplications=no
 
 [Languages]
 Name: "english"; MessagesFile: "compiler:Default.isl"

scripts/tools/chocolateyInstall.ps1

@@ -18,7 +18,7 @@ $packageArgs = @{
   checksum64    = '{{installerChecksum64}}'
   checksumType64= 'sha256'
 
-  silentArgs    = '/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /SP- /RESTARTAPPLICATIONS'
+  silentArgs    = '/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /SP-'
   validExitCodes= @(0)
 }
 

src/AboutDialog.cs

@@ -26,7 +26,7 @@ public AboutDialog()
 
         public static string GetVersionString()
         {
-            string versionStr = Assembly.GetExecutingAssembly().GetName().Version.ToString();
+            string versionStr = UpdateChecker.GetCurrentVersion();
             versionStr = versionStr.Remove(versionStr.Length - 2);
             versionStr += UwpDesktop.IsRunningAsUwp() ? " (UWP)" : string.Empty;
             return versionStr;

src/AppContext.cs

@@ -17,7 +17,7 @@ class AppContext : ApplicationContext
         public static NotifyIcon notifyIcon;
         public static EventScheduler scheduler = new EventScheduler();
 
-        public AppContext(string[] args)
+        public AppContext(string[] args) : base(new HiddenForm())
         {
             JsonConfig.LoadConfig();
             Localization.Initialize();
@@ -96,14 +96,14 @@ private void OnArgumentsReceived(string[] args)
         {
             if (JsonConfig.settings.hideTrayIcon)
             {
-                notifyIcon.ContextMenuStrip.BeginInvoke(ToggleTrayIcon);
+                MainForm.BeginInvoke(ToggleTrayIcon);
             }
 
             ThemeManager.importPaths.AddRange(args);
 
             if (args.Length > 0 && !ThemeManager.importMode)
             {
-                notifyIcon.ContextMenuStrip.BeginInvoke(ThemeManager.SelectTheme);
+                MainForm.BeginInvoke(ThemeManager.SelectTheme);
             }
         }
 

src/DarkUI.cs

@@ -56,13 +56,10 @@ public static void ThemeForm(Form form, bool onInit = true)
 
         public static void UserDefaultAppThemeIsDarkChanged(object sender, bool isDark)
         {
-            AppContext.notifyIcon.ContextMenuStrip.BeginInvoke(() =>
+            foreach (Form form in Application.OpenForms)
             {
-                foreach (Form form in Application.OpenForms)
-                {
-                    ThemeForm(form, false);
-                }
-            });
+                form.BeginInvoke(() => ThemeForm(form, false));
+            }
         }
 
         // Code from https://stackoverflow.com/a/664083/5504760

src/DownloadDialog.cs

@@ -201,7 +201,7 @@ private void OnFormClosing(object sender, FormClosingEventArgs e)
             {
                 try
                 {
-                    System.Threading.Thread.Sleep(100);  // Wait for file to free up
+                    Thread.Sleep(100);  // Wait for file to free up
                     File.Delete(themeZipDest);
                 }
                 catch { /* Do nothing */ }

src/EventScheduler.cs

@@ -190,9 +190,7 @@ private void HandleDisplayEvent(DisplayEvent e)
             catch (Exception exc)
             {
                 LoggingHandler.LogMessage("Error setting wallpaper: {0}", exc.ToString());
-                MessageDialog.ShowWarning(string.Format(Localization.GetTranslation(
-                    "Error occurred when setting wallpaper '{0}':\n\n{1}"),
-                    Path.GetRelativePath(Environment.CurrentDirectory, imagePath), exc.ToString()));
+                LoggingHandler.LogError(UwpDesktop.GetHelper().GetLocalFolder(), exc);
             }
         }
 

src/HiddenForm.cs

@@ -0,0 +1,74 @@
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+using System;
+using System.Runtime.InteropServices;
+using System.Windows.Forms;
+
+namespace WinDynamicDesktop
+{
+    // https://github.com/specshell/specshell.software.winform.hiddenform/blob/main/src/Specshell.WinForm.HiddenForm/HiddenForm.cs
+    internal class HiddenForm : Form
+    {
+        private const int ENDSESSION_CLOSEAPP = 0x1;
+        private const int WM_QUERYENDSESSION = 0x11;
+        private const int WM_ENDSESSION = 0x16;
+
+        [DllImport("user32.dll")]
+        private static extern IntPtr SetParent(IntPtr hWndChild, IntPtr hwndNewParent);
+
+        public HiddenForm()
+        {
+            this.Load += this.HiddenForm_Load;
+        }
+
+        protected override CreateParams CreateParams
+        {
+            get
+            {
+                const int WS_POPUP = unchecked((int)0x80000000);
+                const int WS_EX_TOOLWINDOW = 0x80;
+
+                CreateParams cp = base.CreateParams;
+                cp.ExStyle = WS_EX_TOOLWINDOW;
+                cp.Style = WS_POPUP;
+                cp.Height = 0;
+                cp.Width = 0;
+                return cp;
+            }
+        }
+
+        protected override void WndProc(ref Message m)
+        {
+            // https://github.com/rocksdanister/lively/blob/9142f6a4cfc222cd494f205a5daaa1a0238282e3/src/Lively/Lively/Views/WindowMsg/WndProcMsgWindow.xaml.cs#L41
+            switch (m.Msg)
+            {
+                case WM_QUERYENDSESSION:
+                    if ((m.LParam & ENDSESSION_CLOSEAPP) != 0)
+                    {
+                        UpdateChecker.RegisterApplicationRestart(null, (int)RestartFlags.RESTART_NO_CRASH |
+                            (int)RestartFlags.RESTART_NO_HANG | (int)RestartFlags.RESTART_NO_REBOOT);
+                    }
+                    m.Result = new IntPtr(1);
+                    break;
+                case WM_ENDSESSION:
+                    if (m.WParam != IntPtr.Zero)
+                    {
+                        Application.Exit();
+                    }
+                    m.Result = IntPtr.Zero;
+                    break;
+                default:
+                    base.WndProc(ref m);
+                    break;
+            }
+        }
+
+        private void HiddenForm_Load(object source, EventArgs e)
+        {
+            const int HWND_MESSAGE = -1;
+            SetParent(this.Handle, new IntPtr(HWND_MESSAGE));
+        }
+    }
+}

src/ScheduleDialog.cs

@@ -216,7 +216,7 @@ private void OnFormClosing(object sender, FormClosingEventArgs e)
 
                 if (result == DialogResult.Yes)
                 {
-                    Application.Exit();
+                    Environment.Exit(0);
                 }
                 else
                 {

src/ThemeThumbLoader.cs

@@ -152,7 +152,7 @@ public static void CacheThumbnails(System.Windows.Forms.ListView listView)
 
         private static string CreateBlankWallpaper()
         {
-            string wallpaperPath = Path.Combine(Environment.CurrentDirectory, "wallpaper_blank.jpg");
+            string wallpaperPath = Path.Combine(Path.GetTempPath(), "WinDynamicDesktop_blank_preview.jpg");
             if (!File.Exists(wallpaperPath))
             {
                 (new Bitmap(1, 1)).Save(wallpaperPath, ImageFormat.Jpeg);