fix: documentation button now rediretcs instead of downloading (#2079)

TotalDevNormie · web-flow · commit 3a57dab329b7 · 2025-03-28T20:40:09.000+01:00
Co-authored-by: Total Normie &lt;109313344+TotoalNormie@users.noreply.github.com&gt;
diff --git a/.changeset/loud-actors-return.md b/.changeset/loud-actors-return.md
@@ -0,0 +1,5 @@
+---
+"create-t3-app": patch
+---
+
+Fixed Github issue #2078 related to documentation button downloading istead of redirecting. Changed it by not including the download prop if "download" is falsy. Don't be too harsh, this is my first contribution in my life.
diff --git a/www/src/components/landingPage/button.astro b/www/src/components/landingPage/button.astro
@@ -36,7 +36,7 @@ const specialHoverClass = specialHover
   target={openInNewTab ? "_blank" : "_self"}
   rel="noopener noreferrer"
   class={`${specialHoverClass} ${roundedClass} ${variantClass} ${className} inline-flex items-center px-3 lg:px-4 lg:py-3 md:px-5 py-2 text-sm md:text-base font-semibold cursor-pointer hover:no-underline transition-colors`}
-  download={download}
+  {...download ? { download } : {}}
 >
   <slot />
 </a>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"create-t3-app": patch
 +---
++
 +Fixed Github issue #2078 related to documentation button downloading istead of redirecting. Changed it by not including the download prop if "download" is falsy. Don't be too harsh, this is my first contribution in my life.
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ const specialHoverClass = specialHover`
`36`	`36`	`target={openInNewTab ? "_blank" : "_self"}`
`37`	`37`	`rel="noopener noreferrer"`
`38`	`38`	class={`${specialHoverClass} ${roundedClass} ${variantClass} ${className} inline-flex items-center px-3 lg:px-4 lg:py-3 md:px-5 py-2 text-sm md:text-base font-semibold cursor-pointer hover:no-underline transition-colors`}
`39`		`- download={download}`
	`39`	`+ {...download ? { download } : {}}`
`40`	`40`	`>`
`41`	`41`	`<slot />`
`42`	`42`	`</a>`