Merge pull request #125 from tSQLt-org/TransactionFree

Transaction free

Author: mbt1

CI/Azure-DevOps/AZ_MainPipeline.yml

@@ -88,6 +88,8 @@ stages:
       inputs:
         azureSubscription: 'Azure DevOps Main Pipeline Service Principal'
         KeyVaultName: 'tSQLtSigningKey'
+        SecretsFilter: '*'
+        RunAsPreJob: false
 
     - task: PowerShell@2
       name: CreateResourceGroupName

Experiments/CollationTests.sql

@@ -0,0 +1,37 @@
+/*--
+RELEVANT LINKS
+https://www.red-gate.com/simple-talk/databases/sql-server/t-sql-programming-sql-server/questions-sql-server-collations-shy-ask/
+https://docs.microsoft.com/en-us/sql/t-sql/statements/windows-collation-name-transact-sql?view=sql-server-ver15
+--*/
+
+SELECT DATABASEPROPERTYEX('tempdb','Collation') [tempdb collation],
+       DATABASEPROPERTYEX(DB_NAME(),'Collation') [database collation]
+GO
+
+DROP TABLE IF EXISTS dbo.atable;
+DROP TABLE IF EXISTS tempdb..#Actual;
+SELECT 
+    'Hello World!' COLLATE SQL_Polish_CP1250_CI_AS c1, 
+    'Hello World!' COLLATE SQL_Latin1_General_CP437_BIN c2, 
+    'Hello World!' COLLATE Albanian_BIN2 c3 
+  INTO dbo.atable
+SELECT * INTO #Actual FROM dbo.atable
+
+SELECT 'dbo.atable' [table],* FROM sys.columns WHERE object_id = OBJECT_ID('dbo.atable')
+
+SELECT '#Actual',* FROM tempdb.sys.columns WHERE object_id = OBJECT_ID('tempdb..#Actual');
+
+GO
+
+DROP TABLE IF EXISTS tempdb..#E;
+CREATE TABLE #E(
+  C1 NVARCHAR(MAX) COLLATE DATABASE_DEFAULT,
+  C2 NVARCHAR(MAX)
+);
+
+SELECT '#E',* FROM tempdb.sys.columns WHERE object_id = OBJECT_ID('tempdb..#E');
+GO
+SELECT *
+FROM #E E1
+JOIN #E E2
+ON E2.C2 = E1.C1

Experiments/Debugging tSQLt.tdf

@@ -36,6 +36,12 @@
           <AssociatedConnUserName />
           <FullPath>CertificateTest.sql</FullPath>
         </FileNode>
+        <FileNode Name="CollationTests.sql">
+          <AssociatedConnectionMoniker />
+          <AssociatedConnSrvName />
+          <AssociatedConnUserName />
+          <FullPath>CollationTests.sql</FullPath>
+        </FileNode>
         <FileNode Name="EXPERIMENTS.sql">
           <AssociatedConnectionMoniker />
           <AssociatedConnSrvName />
@@ -60,6 +66,12 @@
           <AssociatedConnUserName />
           <FullPath>LIKE4000.sql</FullPath>
         </FileNode>
+        <FileNode Name="MSSQL Defect Try-Catch Invalidates Transaction.sql">
+          <AssociatedConnectionMoniker />
+          <AssociatedConnSrvName />
+          <AssociatedConnUserName />
+          <FullPath>MSSQL Defect Try-Catch Invalidates Transaction.sql</FullPath>
+        </FileNode>
         <FileNode Name="NameResolutionResearch.sql">
           <AssociatedConnectionMoniker />
           <AssociatedConnSrvName />
@@ -102,6 +114,12 @@
           <AssociatedConnUserName />
           <FullPath>SQLCmdTest.1.sql</FullPath>
         </FileNode>
+        <FileNode Name="TestingTransactionNames.sql">
+          <AssociatedConnectionMoniker />
+          <AssociatedConnSrvName />
+          <AssociatedConnUserName />
+          <FullPath>TestingTransactionNames.sql</FullPath>
+        </FileNode>
         <FileNode Name="tSQLtListObjects.sql">
           <AssociatedConnectionMoniker />
           <AssociatedConnSrvName />

Experiments/Experiments.ssmssqlproj

@@ -0,0 +1,20 @@
+PRINT 'No TRY...CATCH:';
+EXEC ('BEGIN TRAN');
+SELECT XACT_STATE() AS [XACT_STATE()],@@TRANCOUNT AS [@@TRANCOUNT];
+GO
+IF(XACT_STATE()<>0)ROLLBACK;
+GO
+
+
+
+GO
+PRINT 'In TRY...CATCH:';
+BEGIN TRY
+EXEC ('BEGIN TRAN');
+END TRY
+BEGIN CATCH
+END CATCH;
+SELECT XACT_STATE() AS [XACT_STATE()],@@TRANCOUNT AS [@@TRANCOUNT];
+GO
+IF(XACT_STATE()<>0)ROLLBACK;
+GO

Experiments/MSSQL Defect Try-Catch Invalidates Transaction.sql

@@ -0,0 +1,61 @@
+SELECT 
+    R.EventSequence,
+    TE.name,
+    TSV.subclass_name,
+    R.ObjectName,
+    R.LineNumber,
+    R.TransactionID,
+    R.XactSequence,
+    ISNULL(REPLICATE('    ',(R.NestLevel-1)),'')+CAST(R.TextData AS NVARCHAR(MAX)) AS TextData,
+    R.Error,
+    R.Severity,
+    R.NestLevel,
+    R.RowNumber,
+    R.EventClass,
+    R.EventSubClass,
+    R.ApplicationName,
+    R.ClientProcessID,
+    R.DatabaseID,
+    R.DatabaseName,
+    R.GroupID,
+    R.HostName,
+    R.IsSystem,
+    R.LoginName,
+    R.LoginSid,
+    R.NTDomainName,
+    R.NTUserName,
+    R.RequestID,
+    R.SPID,
+    R.ServerName,
+    R.SessionLoginName,
+    R.StartTime,
+    R.Success,
+    R.GUID,
+    R.BinaryData,
+    R.Duration,
+    R.EndTime,
+    R.IntegerData,
+    R.CPU,
+    R.IntegerData2,
+    R.Offset,
+    R.Reads,
+    R.RowCounts,
+    R.Writes,
+    R.State,
+    R.ObjectID,
+    R.ObjectType,
+    R.SourceDatabaseID,
+    R.IndexID,
+    R.Type,
+    R.Mode,
+    R.OwnerID,
+    R.ObjectID2,
+    R.BigintData1
+  FROM dbo.run4 R
+  LEFT JOIN sys.trace_events AS TE
+    ON R.EventClass = TE.trace_event_id
+  LEFT JOIN sys.trace_subclass_values AS TSV
+    ON TSV.trace_event_id = TE.trace_event_id
+   AND R.EventSubClass = TSV.subclass_value
+  WHERE ISNULL(R.ObjectName,'???') NOT IN ('Private_Print','sp_rename', 'sp_validname','GetTestResultFormatter','sp_addextendedproperty','sp_updateextendedproperty')
+  ORDER BY R.EventSequence

Experiments/SM query - read trace table.sql

@@ -0,0 +1,21 @@
+IF(XACT_STATE()<>0)ROLLBACK
+GO
+DROP TABLE IF EXISTS #Actual
+GO
+DECLARE @TranName NVARCHAR(32) = NULL;
+SELECT 1,@@TRANCOUNT
+SELECT 1 X,@@TRANCOUNT TC INTO #Actual
+BEGIN TRAN;
+SELECT 2,@@TRANCOUNT
+INSERT INTO #Actual VALUES(2,@@TRANCOUNT);
+SAVE TRAN @TranName;
+SELECT 3,@@TRANCOUNT
+SELECT * FROM sys.dm_tran_current_transaction AS DTCT JOIN sys.dm_tran_session_transactions 
+AS DTAT ON DTAT.transaction_id = DTCT.transaction_id
+INSERT INTO #Actual VALUES(3,@@TRANCOUNT);
+SELECT * FROM #Actual AS A
+ROLLBACK TRAN @TranName;
+SELECT 4,@@TRANCOUNT
+INSERT INTO #Actual VALUES(4,@@TRANCOUNT);
+COMMIT;
+SELECT * FROM #Actual AS A

Experiments/TestingTransactionNames.sql

@@ -45,6 +45,7 @@ BEGIN
          @CreateProcedureStatement = @CreateProcedureStatement OUT,
          @LogTableName = NULL,
          @CommandToExecute = NULL,
+         @CallOriginal = 0,
          @CreateLogTableStatement = NULL;
 
   EXEC Facade.CreateSchemaIfNotExists @FacadeDbName = @FacadeDbName, @SchemaName = @SchemaName;

Facade/Facade.CreateAllObjects.ssp.sql

@@ -3,6 +3,7 @@ tSQLt._Header.sql
 tSQLt.schema.sql
 tSQLt.TestClass.user.sql
 tSQLt.Private_GetDropItemCmd.sfn.sql
+tSQLt.Private_Results.view.sql
 tSQLt.DropClass.ssp.sql
 tSQLt.Uninstall.ssp.sql
 tSQLt.TestClasses.view.sql
@@ -41,6 +42,8 @@ tSQLt.Private_RenameObjectToUniqueName.ssp.sql
 tSQLt.Private_RenameObjectToUniqueNameUsingObjectId.ssp.sql
 tSQLt.RemoveObject.ssp.sql
 tSQLt.RemoveObjectIfExists.ssp.sql
+tSQLt.Private_GetFormattedErrorInfo.sfn.sql
+tSQLt.Private_HandleMessageAndResult.sfn.sql
 tSQLt.Private_CleanTestResult.ssp.sql
 tSQLt.Private_ListTestAnnotations.sfn.sql
 tSQLt.Private_ProcessTestAnnotations.ssp.sql
@@ -50,8 +53,16 @@ tSQLt.Private_SqlVersion.sfn.sql
 tSQLt.Private_SplitSqlVersion.sfn.sql
 tSQLt.FriendlySQLServerVersion.sfn.sql
 tSQLt.Info.sfn.sql
+tSQLt.Private_Seize.tbl.sql
 tSQLt.Private_Init.ssp.sql
 tSQLt.Private_HostPlatform.svw.sql
+tSQLt.Private_NoTransactionTableAction.view.sql
+tSQLt.Private_NoTransactionHandleTable.ssp.sql
+tSQLt.Private_NoTransactionHandleTables.ssp.sql
+tSQLt.Private_CleanUpCmdHandler.ssp.sql
+tSQLt.Private_CleanUp.ssp.sql
+tSQLt.Private_AssertNoSideEffects_GenerateCommand.sfn.sql
+tSQLt.Private_AssertNoSideEffects.ssp.sql
 Run_Methods.sql
 tSQLt.Private_SysTypes.svw.sql
 tSQLt.Private_GetFullTypeName.sfn.sql
@@ -60,6 +71,7 @@ tSQLt.Private_ScriptIndex.sfn.sql
 tSQLt.Private_RemoveSchemaBinding.ssp.sql
 tSQLt.Private_RemoveSchemaBoundReferences.ssp.sql
 tSQLt.Private_GetForeignKeyDefinition.sfn.sql
+tSQLt.Private_MarktSQLtTempObject.ssp.sql
 ApplyConstraint_Methods.sql
 tSQLt.Private_ValidateFakeTableParameters.ssp.sql
 tSQLt.Private_GetDataTypeOrComputedColumnDefinition.sfn.sql
@@ -68,17 +80,16 @@ tSQLt.Private_GetDefaultConstraintDefinition.sfn.sql
 tSQLt.Private_GetUniqueConstraintDefinition.sfn.sql
 tSQLt.Private_CreateFakeTableStatement.sfn.sql
 tSQLt.Private_CreateFakeOfTable.ssp.sql
-tSQLt.Private_MarktSQLtTempObject.ssp.sql
 tSQLt.FakeTable.ssp.sql
 tSQLt.Private_GenerateCreateProcedureSpyStatement.ssp.sql
 tSQLt.Private_CreateProcedureSpy.ssp.sql
+tSQLt.Private_ValidateProcedureCanBeUsedWithSpyProcedure.ssp.sql
 tSQLt.SpyProcedure.ssp.sql
 tSQLt.Private_GetCommaSeparatedColumnList.sfn.sql
 tSQLt.Private_CreateResultTableForCompareTables.ssp.sql
 tSQLt.Private_ValidateThatAllDataTypesInTableAreSupported.ssp.sql
 tSQLt.Private_CompareTablesFailIfUnequalRowsExists.ssp.sql
 tSQLt.Private_CompareTables.ssp.sql
-tSQLt.Private_NullCellTable.tbl.sql
 tSQLt.AssertObjectExists.ssp.sql
 tSQLt.AssertObjectDoesNotExist.ssp.sql
 tSQLt.AssertEqualsString.ssp.sql
@@ -94,7 +105,6 @@ tSQLt.Private_ValidateObjectsCompatibleWithFakeFunction.ssp.sql
 tSQLt.Private_CreateFakeFunction.ssp.sql
 tSQLt.FakeFunction.ssp.sql
 tSQLt.RenameClass.ssp.sql
-tSQLt.AssertEqualsTableSchema.tables.sql
 tSQLt.AssertEqualsTableSchema.ssp.sql
 tSQLt.AssertStringTable.udt.sql
 tSQLt.AssertStringIn.ssp.sql
@@ -105,6 +115,7 @@ tSQLt.(at)tSQLt_SkipTest.sfn.sql
 tSQLt.(at)tSQLt_MinSqlMajorVersion.sfn.sql
 tSQLt.(at)tSQLt_MaxSqlMajorVersion.sfn.sql
 tSQLt.(at)tSQLt_RunOnlyOnHostPlatform.sfn.sql
+tSQLt.(at)tSQLt_NoTransaction.sfn.sql
 tSQLt.RemoveExternalAccessKey.ssp.sql
 tSQLt.InstallExternalAccessKey.ssp.sql
 tSQLt.Private_InstallationInfo.sfn.sql