Skip to content

Commit 56b432f

Browse files
author
mbt1
committed
removed superfluous quotes from LocalBuild.bat
added missing parameter to printout finished remaining tests for PR #16
1 parent 22fe62a commit 56b432f

File tree

4 files changed

+47
-21
lines changed

4 files changed

+47
-21
lines changed

Build/LocalBuild.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ ECHO +-------------------------+
4646
ECHO : Validating BUILD :
4747
ECHO +-------------------------+
4848
IF "%~7"=="-v" @ECHO ON
49-
CALL "%~1\bin\ant" -buildfile Build\tSQLt.validatebuild.xml -Ddb.server="%~4" -Ddb.name=%~5 -Ddb.login="%DBLogin%" -Dsqlcmd.path="\"%~3\"" || goto :error
49+
CALL "%~1\bin\ant" -buildfile Build\tSQLt.validatebuild.xml -Ddb.server="%~4" -Ddb.name=%~5 -Ddb.login="%DBLogin%" -Dsqlcmd.path="%~3" || goto :error
5050
@ECHO OFF
5151

5252
ECHO +-------------------------+

Build/tSQLt.validatebuild.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
<echo message="db.server: ${db.server}" />
3838
<echo message="db.name: ${db.name}" />
3939
<echo message="db.login: ${db.login}" />
40+
<echo message="sqlcmd.path: ${sqlcmd.path}" />
4041

4142
</target>
4243

Tests/ApplyConstraintTests.class.sql

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -844,6 +844,50 @@ BEGIN
844844
END;
845845
GO
846846

847+
CREATE PROC ApplyConstraintTests.[test ApplyConstraint can handle data types with length when changing NULLability]
848+
AS
849+
BEGIN
850+
EXEC('CREATE SCHEMA schemaA;');
851+
CREATE TABLE schemaA.tableA (
852+
Length1 VARCHAR(42) NOT NULL,
853+
CONSTRAINT testConstraint PRIMARY KEY (Length1)
854+
);
855+
856+
EXEC tSQLt.FakeTable 'schemaA.tableA';
857+
858+
EXEC tSQLt.ExpectNoException;
859+
INSERT INTO schemaA.tableA(Length1)VALUES(NULL);
860+
TRUNCATE TABLE schemaA.tableA;
861+
862+
EXEC tSQLt.ApplyConstraint 'schemaA.tableA', 'testConstraint';
863+
864+
EXEC tSQLt.ExpectException @ExpectedMessagePattern = '%Cannot insert the value NULL%Length1%';
865+
INSERT INTO schemaA.tableA(Length1)VALUES(NULL);
866+
END;
867+
GO
868+
869+
CREATE PROC ApplyConstraintTests.[test ApplyConstraint can handle data types with precision and scale when changing NULLability]
870+
AS
871+
BEGIN
872+
EXEC('CREATE SCHEMA schemaA;');
873+
CREATE TABLE schemaA.tableA (
874+
Precision_Scale NUMERIC(21,3) NOT NULL,
875+
CONSTRAINT testConstraint PRIMARY KEY (Precision_Scale)
876+
);
877+
878+
EXEC tSQLt.FakeTable 'schemaA.tableA';
879+
880+
EXEC tSQLt.ExpectNoException;
881+
INSERT INTO schemaA.tableA(Precision_Scale)VALUES(NULL);
882+
TRUNCATE TABLE schemaA.tableA;
883+
884+
EXEC tSQLt.ApplyConstraint 'schemaA.tableA', 'testConstraint';
885+
886+
EXEC tSQLt.ExpectException @ExpectedMessagePattern = '%Cannot insert the value NULL%Precision_Scale%';
887+
INSERT INTO schemaA.tableA(Precision_Scale)VALUES(NULL);
888+
END;
889+
GO
890+
847891
CREATE PROC ApplyConstraintTests.[test ApplyConstraint applies multi-column unique constraint]
848892
AS
849893
BEGIN

Tests/FakeTableTests.class.sql

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -17,25 +17,6 @@
1717
EXEC tSQLt.NewTestClass 'FakeTableTests';
1818
GO
1919

20-
CREATE PROC FakeTableTests.[test that no disabled tests exist]
21-
AS
22-
BEGIN
23-
SELECT name
24-
INTO #Actual
25-
FROM sys.procedures
26-
WHERE (
27-
LOWER(name) LIKE '_test%'
28-
OR LOWER(name) LIKE 't_est%'
29-
OR LOWER(name) LIKE 'te_st%'
30-
OR LOWER(name) LIKE 'tes_t%'
31-
)
32-
AND schema_id = SCHEMA_ID(OBJECT_SCHEMA_NAME(@@PROCID));
33-
34-
SELECT TOP(0) * INTO #Expected FROM #Actual;
35-
EXEC tSQLt.AssertEqualsTable '#Expected','#Actual';
36-
END;
37-
GO
38-
3920
CREATE PROC FakeTableTests.AssertTableIsNewObjectThatHasNoConstraints
4021
@TableName NVARCHAR(MAX)
4122
AS
@@ -393,7 +374,7 @@ BEGIN
393374

394375
CREATE TABLE dbo.tst1(Length1 VARCHAR(42), Length2 VARCHAR(MAX), Precision_Scale NUMERIC(21,3));
395376

396-
SELECT top(1) column_id,name,max_length, precision, scale
377+
SELECT column_id,name,max_length, precision, scale
397378
INTO #Expected
398379
FROM sys.columns
399380
WHERE object_id = OBJECT_ID('dbo.tst1')

0 commit comments

Comments
 (0)