Clean up from Pull Request Review

Author: lizbaron

Build/CreateDropClassStatement.ps1

@@ -41,70 +41,13 @@ $DropClassStatement = ($RawDropClassStatement.trim()|Where-Object {$_ -ne "" -an
 
 Set-Content -Path $OutputFilePath -Value $DropClassStatement;
 
-<#
-TODO --> Test this: Empty File TempDropClass.sql file should throw an error
-TODO --> Test this: If the $tempPath does not exist, BuildHelper.exe seems to currently throw an error, but does that stop the build?
-TODO --> Test this: If the $sourcePath does not exist, BuildHelper.exe seems to currently throw an error, but does that stop the build?
-#>
-
-<#
-# Read file and remove all empty lines
-$fileContent = (Get-Content -path ($tempPath+"TempDropClass.sql")).trim() | Where-Object {$_ -ne "" -and $_ -notmatch "^GO(\s.*)?"};
-
-# Make sure that the file is not empty
-if($fileContent.length -eq 0) {
-  throw "Length of fileContent is zero";
-}
-
-# trim lines and jam them all together with a space in between
-$singleLineContent = $fileContent -join " ";
-
-<replaceregexp match="^.*?BEGIN" replace="---Build+${line.separator}DECLARE @ClassName NVARCHAR(MAX) ='tSQLt';BEGIN" flags="gm" byline="false" file="temp/tSQLtBuild/TempDropClass.sql" />
-
-#>
-
-<#
-if ($LoginTrimmed -match '((.*[-]U)|(.*[-]P))+.*'){
-  $AuthenticationString = $LoginTrimmed -replace '^((\s*([-]U\s+)(?<user>\w+)\s*)|(\s*([-]P\s+)(?<password>\S+)\s*))+$', 'User Id=${user};Password="${password}"'  
-}
-#>
-
-<# We need to replace this target with a exec target which calls a ps1 to do this work.
-In addition, we will add a replace which will "in line" the relevant text of tSQLt.Private_GetDropItemCmd.
-
-"suggested (◔_◔)" regex: tSQLt.Private_GetDropItemCmd(Ds.FullName, Ds.ItemType)
-'tSQLt\s*.\s*Private_GetDropItemCmd\s*\(\s*([^,]*)\s*,\s*([^)]*)\s*\)'
-
-It should look like this:
-
-
-
-DECLARE @ClassName NVARCHAR(MAX) ='tSQLt';BEGIN DECLARE @Cmd NVARCHAR(MAX); WITH ObjectInfo(FullName, ItemType) AS ( SELECT QUOTENAME(SCHEMA_NAME(O.schema_id))+'.'+QUOTENAME(O.name), O.type FROM sys.objects AS O WHERE O.schema_id = SCHEMA_ID(@ClassName) ), TypeInfo(FullName, ItemType) AS ( SELECT QUOTENAME(SCHEMA_NAME(T.schema_id))+'.'+QUOTENAME(T.name), 'type' FROM sys.types AS T WHERE T.schema_id = SCHEMA_ID(@ClassName) ), XMLSchemaInfo(FullName, ItemType) AS ( SELECT QUOTENAME(SCHEMA_NAME(XSC.schema_id))+'.'+QUOTENAME(XSC.name), 'xml_schema_collections' FROM sys.xml_schema_collections AS XSC WHERE XSC.schema_id = SCHEMA_ID(@ClassName) ), SchemaInfo(FullName, ItemType) AS ( SELECT QUOTENAME(S.name), 'schema' FROM sys.schemas AS S WHERE S.schema_id = SCHEMA_ID(PARSENAME(@ClassName,1)) ), DropStatements(no,FullName,ItemType) AS ( SELECT 10, FullName, ItemType FROM ObjectInfo UNION ALL SELECT 20, FullName, ItemType FROM TypeInfo UNION ALL SELECT 30, FullName, ItemType FROM XMLSchemaInfo UNION ALL SELECT 10000, FullName, ItemType FROM SchemaInfo ), StatementBlob(xml)AS ( SELECT GDIC.cmd [text()] FROM DropStatements DS CROSS APPLY 
-(
-SELECT
-   'DROP ' +
-   CASE @ItemType 
-     WHEN 'P' THEN 'PROCEDURE'
-     WHEN 'PC' THEN 'PROCEDURE'
-     WHEN 'U' THEN 'TABLE'
-     WHEN 'IF' THEN 'FUNCTION'
-     WHEN 'TF' THEN 'FUNCTION'
-     WHEN 'FN' THEN 'FUNCTION'
-     WHEN 'FT' THEN 'FUNCTION'
-     WHEN 'V' THEN 'VIEW'
-     WHEN 'type' THEN 'TYPE'
-     WHEN 'xml_schema_collection' THEN 'XML SCHEMA COLLECTION'
-     WHEN 'schema' THEN 'SCHEMA'
-    END+
-    ' ' + 
-    @FullName + 
-    ';' AS cmd
-)
-GDIC ORDER BY no FOR XML PATH(''), TYPE ) SELECT @Cmd = xml.value('/', 'NVARCHAR(MAX)') FROM StatementBlob; EXEC(@Cmd); END;
-
-#>
-
  Log-Output '<#--=======================================================================-->'
  Log-Output '<!--========            End CreateDropClassStatement.ps1          =========-->'
  Log-Output '<#--=======================================================================-->'
- 
+ 
+ 
+<# TODO
+--> Test this: Empty File TempDropClass.sql file should throw an error
+--> Test this: If the $tempPath does not exist, BuildHelper.exe seems to currently throw an error, but does that stop the build?
+--> Test this: If the $sourcePath does not exist, BuildHelper.exe seems to currently throw an error, but does that stop the build?
+#>

Source/tSQLt.Private_GetDropItemCmd.sfn.sql

@@ -33,4 +33,46 @@ SELECT
      @FullName + 
      ';' AS cmd
 /*SnipEnd: CreateDropClassStatement.ps1*/
-GO
+GO
+---Build-
+/*
+Object type:
+  AF = Aggregate function (CLR)
+-  C = CHECK constraint
+-  D = DEFAULT (constraint or stand-alone)
+-  F = FOREIGN KEY constraint
++  FN = SQL scalar function
+  FS = Assembly (CLR) scalar-function
++  FT = Assembly (CLR) table-valued function
++  IF = SQL inline table-valued function
+  IT = Internal table
++  P = SQL Stored Procedure
++  PC = Assembly (CLR) stored-procedure
+-  PG = Plan guide
+-  PK = PRIMARY KEY constraint
+?  R = Rule (old-style, stand-alone)
+  RF = Replication-filter-procedure
+-  S = System base table
+  SN = Synonym
+  SO = Sequence object
++  U = Table (user-defined)
++  V = View
+-  EC = Edge constraint
+
+Applies to: SQL Server 2012 (11.x) and later.
+  SQ = Service queue
+ - TA = Assembly (CLR) DML trigger
+ + TF = SQL table-valued-function
+ - TR = SQL DML trigger
+  TT = Table type
+ - UQ = UNIQUE constraint
+ ? X = Extended stored procedure
+
+Applies to: SQL Server 2014 (12.x) and later, Azure SQL Database, Azure Synapse Analytics, Analytics Platform System (PDW).
+ ? ST = STATS_TREE
+
+Applies to: SQL Server 2016 (13.x) and later, Azure SQL Database, Azure Synapse Analytics, Analytics Platform System (PDW).
+  ET = External Table
+
+Also think about schema bound objects (an exercise in sorting?? because they need to be dropped in the correct order so that you don't drop parent objects before the child objects)
+*/

Tests/DropClassTests.class.sql

@@ -129,61 +129,6 @@ CREATE FUNCTION MyTestClass.AClrTvf(@p1 NVARCHAR(MAX), @p2 NVARCHAR(MAX))
     END
 END;
 GO
-                  --CASE type *WHEN 'P' THEN 'PROCEDURE'
-                  --          *WHEN 'PC' THEN 'PROCEDURE'
-                  --          *WHEN 'U' THEN 'TABLE'
-                  --          WHEN 'IF' THEN 'FUNCTION'
-                  --          *WHEN 'TF' THEN 'FUNCTION'
-                  --          WHEN 'FN' THEN 'FUNCTION'
-                  --          *WHEN 'FT' THEN 'FUNCTION'
-                  --          *WHEN 'V' THEN 'VIEW'
-                  -- *XML
-                  -- *UDDT
-/*
-Object type:
-  AF = Aggregate function (CLR)
--  C = CHECK constraint
--  D = DEFAULT (constraint or stand-alone)
--  F = FOREIGN KEY constraint
-+  FN = SQL scalar function
-  FS = Assembly (CLR) scalar-function
-+  FT = Assembly (CLR) table-valued function
-+  IF = SQL inline table-valued function
-  IT = Internal table
-+  P = SQL Stored Procedure
-+  PC = Assembly (CLR) stored-procedure
--  PG = Plan guide
--  PK = PRIMARY KEY constraint
-?  R = Rule (old-style, stand-alone)
-  RF = Replication-filter-procedure
--  S = System base table
-  SN = Synonym
-  SO = Sequence object
-+  U = Table (user-defined)
-+  V = View
--  EC = Edge constraint
-
-Applies to: SQL Server 2012 (11.x) and later.
-  SQ = Service queue
- - TA = Assembly (CLR) DML trigger
- + TF = SQL table-valued-function
- - TR = SQL DML trigger
-  TT = Table type
- - UQ = UNIQUE constraint
- ? X = Extended stored procedure
-
-Applies to: SQL Server 2014 (12.x) and later, Azure SQL Database, Azure Synapse Analytics, Analytics Platform System (PDW).
- ? ST = STATS_TREE
-
-Applies to: SQL Server 2016 (13.x) and later, Azure SQL Database, Azure Synapse Analytics, Analytics Platform System (PDW).
-  ET = External Table
-
-Also think about schema bound objects (an exercise in sorting?? because they need to be dropped in the correct order so that you don't drop parent objects before the child objects)
-*/
-
-/*-- random line because someone can't use ctrl-9 through zoom
-EXEC tSQLt.Run DropClassTests
---*/
 CREATE PROC DropClassTests.[test removes SSPs]
 AS
 BEGIN

Tests/FakeFunctionTests.class.sql

@@ -661,7 +661,8 @@ BEGIN
   EXEC tSQLt.AssertEqualsTable 'FakeFunctionTests.Expected', @NewTable;
 END;
 GO
--- THIS CODE FEELS UNNECESSARY
+-- THIS CODE CREATES THE SNAPSHOT.
+-- When we revisit creating something like FakeFunctionWithSnapshot, we should refer back.
 -- DECLARE @newTbleName NVARCHAR(MAX);
 -- EXEC tSQLt.Private_PrepareFakeFunctionOutputTable @FakeDataSource, @newTbleName OUTPUT;