Working on including #16 because the original patch did not work (maybe it was updated by hand). Adding required tests (both for this PR and because some were missing): One is currently breaking on purpose. Please fix it. There is at least one more test required to ensure unique constraints.

Author: lizbaron

Source/tSQLt.Private_GetFullTypeName.sfn.sql

@@ -17,6 +17,8 @@ FROM(
                     THEN '(' + CAST(@Length AS NVARCHAR) + ')'
                    WHEN T.name IN ('decimal', 'numeric')
                     THEN '(' + CAST(@Precision AS NVARCHAR) + ',' + CAST(@Scale AS NVARCHAR) + ')'
+                   WHEN T.name IN ('datetime2', 'datetimeoffset', 'time')
+                    THEN '(' + CAST(@Scale AS NVARCHAR) + ')'					
                    ELSE ''
                END Suffix,
               CASE WHEN @CollationName IS NULL OR T.is_user_defined = 1 THEN ''

Tests/FakeTableTests.class.sql

@@ -385,6 +385,29 @@ BEGIN
   EXEC tSQLt.AssertEqualsTable '#Expected','#Actual';
 END;
 GO
+
+CREATE PROC FakeTableTests.[test FakeTable handles column length, precision, and scale]
+AS
+BEGIN
+  IF OBJECT_ID('dbo.tst1') IS NOT NULL DROP TABLE dbo.tst1;
+
+  CREATE TABLE dbo.tst1(Length1 VARCHAR(42), Length2 VARCHAR(MAX), Precision_Scale NUMERIC(21,3));
+
+  SELECT top(1) column_id,name,max_length, precision, scale
+    INTO #Expected
+    FROM sys.columns
+   WHERE object_id = OBJECT_ID('dbo.tst1')
+  
+  EXEC tSQLt.FakeTable 'dbo.tst1';
+
+  SELECT column_id,name,max_length, precision, scale
+    INTO #Actual
+    FROM sys.columns
+   WHERE object_id = OBJECT_ID('dbo.tst1')
+
+  EXEC tSQLt.AssertEqualsTable '#Expected','#Actual';
+END;
+GO
 
 CREATE PROC FakeTableTests.[test FakeTable works with ugly column and table names]
 AS

Tests/Private_GetFullTypeNameTests.class.sql

@@ -90,6 +90,42 @@ BEGIN
 END
 GO
 
+CREATE PROC Private_GetFullTypeNameTests.[test Private_GetFullTypeName should properly return DATETIME2 parameters]
+AS
+BEGIN
+    DECLARE @Result VARCHAR(MAX);
+
+    SELECT @Result = TypeName
+     FROM tSQLt.Private_GetFullTypeName(TYPE_ID('datetime2'), NULL, NULL, 3, NULL);
+
+    EXEC tSQLt.AssertEqualsString '[sys].[datetime2](3)', @Result;
+END
+GO
+
+CREATE PROC Private_GetFullTypeNameTests.[test Private_GetFullTypeName should properly return TIME parameters]
+AS
+BEGIN
+    DECLARE @Result VARCHAR(MAX);
+
+    SELECT @Result = TypeName
+     FROM tSQLt.Private_GetFullTypeName(TYPE_ID('time'), NULL, NULL, 4, NULL);
+
+    EXEC tSQLt.AssertEqualsString '[sys].[time](4)', @Result;
+END
+GO
+
+CREATE PROC Private_GetFullTypeNameTests.[test Private_GetFullTypeName should properly return DATETIMEOFFSET parameters]
+AS
+BEGIN
+    DECLARE @Result VARCHAR(MAX);
+
+    SELECT @Result = TypeName
+     FROM tSQLt.Private_GetFullTypeName(TYPE_ID('datetimeoffset'), NULL, NULL, 6, NULL);
+
+    EXEC tSQLt.AssertEqualsString '[sys].[datetimeoffset](6)', @Result;
+END
+GO
+
 CREATE PROC Private_GetFullTypeNameTests.[test Private_GetFullTypeName should properly return typeName when all parameters are valued]
 AS
 BEGIN
@@ -251,12 +287,12 @@ BEGIN
   );
 
   INSERT INTO dbo.Parms(ColumnName, ColumnType) VALUES ('[sys.date]', '[sys].[date]');
-  INSERT INTO dbo.Parms(ColumnName, ColumnType) VALUES ('[sys.datetime2]', '[sys].[datetime2]');
-  INSERT INTO dbo.Parms(ColumnName, ColumnType) VALUES ('[sys.datetimeoffset]', '[sys].[datetimeoffset]');
+  INSERT INTO dbo.Parms(ColumnName, ColumnType) VALUES ('[sys.datetime2]', '[sys].[datetime2](7)');
+  INSERT INTO dbo.Parms(ColumnName, ColumnType) VALUES ('[sys.datetimeoffset]', '[sys].[datetimeoffset](7)');
   INSERT INTO dbo.Parms(ColumnName, ColumnType) VALUES ('[sys.geography]', '[sys].[geography]');
   INSERT INTO dbo.Parms(ColumnName, ColumnType) VALUES ('[sys.geometry]', '[sys].[geometry]');
   INSERT INTO dbo.Parms(ColumnName, ColumnType) VALUES ('[sys.hierarchyid]', '[sys].[hierarchyid]');
-  INSERT INTO dbo.Parms(ColumnName, ColumnType) VALUES ('[sys.time]', '[sys].[time]');
+  INSERT INTO dbo.Parms(ColumnName, ColumnType) VALUES ('[sys.time]', '[sys].[time](7)');
 
   DECLARE @Cmd NVARCHAR(MAX);
   SET @Cmd = STUFF((

Tests/SpyProcedureTests.class.sql

@@ -545,6 +545,30 @@ BEGIN
     EXEC tSQLt.AssertEqualsTable '#Expected','#Actual';
 END;
 GO
+CREATE PROC SpyProcedureTests.[test SpyProcedure handles length, precision, and scale correctly]
+  AS
+BEGIN
+    EXEC('CREATE PROC dbo.InnerProcedure(
+             @LENGTH1 VARCHAR(42) ,
+             @LENGTH2 VARCHAR(MAX) ,
+             @PRECISION_SCALE NUMERIC(21, 13) 
+          )
+          AS BEGIN RETURN 0; END');
+    SELECT name, parameter_id, system_type_id, user_type_id, max_length, precision, scale 
+      INTO #Expected
+      FROM sys.parameters
+     WHERE object_id = OBJECT_ID('dbo.InnerProcedure');
+
+    EXEC tSQLt.SpyProcedure 'dbo.InnerProcedure'
+
+    SELECT name, parameter_id, system_type_id, user_type_id, max_length, precision, scale 
+      INTO #Actual
+      FROM sys.parameters
+     WHERE object_id = OBJECT_ID('dbo.InnerProcedure');
+
+    EXEC tSQLt.AssertEqualsTable '#Expected','#Actual';
+END;
+GO
 CREATE PROC SpyProcedureTests.[test SpyProcedure fails with error if spyee has more than 1020 parameters]
 AS
 BEGIN