update to allow users to update functions without redefining them locally

Author: jmoens

tabpy/tabpy_server/handlers/management_handler.py

@@ -47,7 +47,7 @@ def _add_or_update_endpoint(self, action, name, version, request_data):
         """
         Add or update an endpoint
         """
-        self.logger.log(logging.DEBUG, f"Adding/updating model {name}...")
+        self.logger.log(logging.INFO, f"Adding/updating model {name}...")
 
         if not isinstance(name, str):
             msg = "Endpoint name must be a string"

tabpy/tabpy_server/management/state.py

@@ -428,36 +428,6 @@ def delete_endpoint(self, name):
             logger.error(f"Unable to delete endpoint {e}")
             raise ValueError(f"Unable to delete endpoint: {e}")
 
-
-    @state_lock
-    def make_endpoint_public(self, name):
-        """
-        Updates an existing endpoint on the TabPy Server to be public
-
-        Parameters
-        ----------
-        name : str
-            The name of the endpoint to be updated.
-
-        Returns
-        -------
-        updated endpoint object
-
-        """
-        if not name or name == "":
-            raise ValueError("Name of the endpoint must be a valid string.")
-        endpoints = self.get_endpoints()
-        if name not in endpoints:
-            raise ValueError(f"Endpoint {name} does not exist.")
-
-        endpoint_to_update = endpoints[name]
-
-        
-        self.update_endpoint(
-            name,
-            is_public=True
-        )
-
     @property
     def name(self):
         """

tabpy/tabpy_tools/client.py

@@ -264,16 +264,55 @@ def remove(self, name):
             Endpoint name to remove'''
         self._service.remove_endpoint(name)
 
-    def make_public(self, name):
-        '''Makes an existing endpoint public.
+    def update(self, name, description=None, schema=None, is_public=None):
+        '''Updates description, schema, or is public for an existing endpoint
 
         Parameters
         ----------
         name : str
-            Endpoint name to make public'''
+            Endpoint name to make public
+
+        description : str, optional
+            The description for the endpoint. This string will be returned by
+            the ``endpoints`` API.
+
+        schema : dict, optional
+            The schema of the function, containing information about input and
+            output parameters, and respective examples. Providing a schema for
+            a deployed function lets other users of the service discover how to
+            use it. Refer to schema.generate_schema for more information on
+            how to generate the schema.
+
+        is_public : bool, optional
+            Whether a function should be public for viewing from within tableau. If
+            False, function will not appear in the custom functions explorer within
+            Tableau. If True, function will be visible ta anyone on a site with this
+            analytics extension configured
+        '''
 
         endpoint = self.get_endpoints().get(name)
-        self._service.make_public(endpoint)
+
+        if not endpoint:
+            raise RuntimeError(
+                f"No endpoint with that name ({name}) exists"
+                " Please select an existing endpoint to update"
+            )
+
+        if description is not None:
+            endpoint.description = description
+        if schema is not None:
+            endpoint.schema = schema
+        if is_public is not None:
+            endpoint.is_public = is_public
+
+        dest_path = self._get_endpoint_upload_destination()
+
+        # Upload the endpoint
+        endpoint.src_path = os.path.join(
+            dest_path, "endpoints", endpoint.name, str(endpoint.version)
+        )
+
+        self._service.set_endpoint(endpoint)
 
     def _gen_endpoint(self, name, obj, description, version=1, schema=None, is_public=False):
         """Generates an endpoint dict.