Skip to content

Accept proxy setting in tabpy-deploy-modelsΒ #467

@ElPincheTopo

Description

@ElPincheTopo

tabpy-deploy-models runs SentimentAnalysis.py which runs:

nltk.download("vader_lexicon")
nltk.download("punkt")

This fails if you are running in environments without direct connection to the internet. nltk supports setting a proxy for the downloads, so I propose adding a cmd line argument to pass the proxy address to tabpy-deploy-models and this would pass it to all the scripts in case any other script needs it. For now, only SentimentAnalysis.py and we just need to get the cmd arg pass it to nltk.set_proxy().

I'm happy to do this but I would like to know if the team behind TabPy likes the approach and would accept my Pull request.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions