Skip to content

Commit 2310a51

Browse files
committed
Fix the filter example, and update typescript compiler version
1 parent e40ef11 commit 2310a51

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Samples-Typescript/Filtering/filtering.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ import {
155155

156156
dashboard.worksheets.forEach(function(worksheet) {
157157
worksheet.getFiltersAsync().then(async (filtersForWorksheet) => {
158+
console.log(filtersForWorksheet);
158159
const filterClearPromises = [];
159160

160161
filtersForWorksheet.forEach(function(filter) {
@@ -163,7 +164,7 @@ import {
163164

164165
// Same pattern as in fetchFilters, wait until all promises have finished
165166
// before updating the UI state.
166-
await Promise.all(filterClearPromises);
167+
await Promise.allSettled(filterClearPromises);
167168
this.updateUIState(false);
168169
});
169170
}, this);

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"description": "Sample code and documentation for the Tableau Extensions API.",
55
"scripts": {
66
"build": "npm run lint && webpack --config webpack.config.js --display-error-details",
7-
"start": "node node_modules/http-server/bin/http-server -p 8765",
7+
"start": "node node_modules/http-server/bin/http-server -p 8765 -c-1",
88
"start-sandbox": "npx tabextsandbox --config sandbox-config.json",
99
"lint": "npm run jslint && npm run tslint",
1010
"jslint": "semistandard ./Samples/*/*.js",
@@ -28,7 +28,7 @@
2828
"semistandard": "^11.0.0",
2929
"ts-loader": "^5.4.5",
3030
"tslint": "^5.16.0",
31-
"typescript": "^3.4.5",
31+
"typescript": "^3.9.10",
3232
"webpack": "^4.30.0",
3333
"webpack-cli": "^3.3.1"
3434
},

0 commit comments

Comments
 (0)