Skip to content

Commit bb8d7c0

Browse files
authored
Merge pull request #398 from tableau/fix-filter-example
Fix the filter example, and update typescript compiler version. Notice that this uses Promise.allSettled which is not supported in IE or older browsers.
2 parents cd121f6 + 9876170 commit bb8d7c0

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Samples-Typescript/Filtering/filtering.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ import {
163163

164164
// Same pattern as in fetchFilters, wait until all promises have finished
165165
// before updating the UI state.
166-
await Promise.all(filterClearPromises);
166+
await Promise.allSettled(filterClearPromises);
167167
this.updateUIState(false);
168168
});
169169
}, this);

Samples/Filtering/filtering.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@
144144

145145
// Same pattern as in fetchFilters, wait until all promises have finished
146146
// before updating the UI state.
147-
Promise.all(filterClearPromises).then(function () {
147+
Promise.allSettled(filterClearPromises).then(function () {
148148
updateUIState(false);
149149
});
150150
});

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"semistandard": "^11.0.0",
2929
"ts-loader": "^5.4.5",
3030
"tslint": "^5.16.0",
31-
"typescript": "^3.4.5",
31+
"typescript": "^3.9.10",
3232
"webpack": "^4.30.0",
3333
"webpack-cli": "^3.3.1"
3434
},

0 commit comments

Comments
 (0)