Addressing comment

Author: gaoang2148

samples/publish_workbook.py

@@ -29,7 +29,7 @@ def main():
     parser.add_argument('--filepath', '-f', required=True, help='filepath to the workbook to publish')
     parser.add_argument('--logging-level', '-l', choices=['debug', 'info', 'error'], default='error',
                         help='desired logging level (set to error by default)')
-    parser.add_argument('--as_job', '-a', help='Publishing asynchronously', action='store_true')
+    parser.add_argument('--as-job', '-a', help='Publishing asynchronously', action='store_true')
 
     args = parser.parse_args()
 
@@ -54,7 +54,7 @@ def main():
         # Step 3: If default project is found, form a new workbook item and publish.
         if default_project is not None:
             new_workbook = TSC.WorkbookItem(default_project.id)
-            if args.as_job is True:
+            if args.as_job:
                 new_job = server.workbooks.publish(new_workbook, args.filepath, overwrite_true, args.as_job)
                 print("Workbook published. JOB ID: {0}".format(new_job.id))
             else:

tableauserverclient/server/endpoint/datasources_endpoint.py

@@ -152,7 +152,7 @@ def refresh(self, datasource_item):
     # Publish datasource
     @api(version="2.0")
     @parameter_added_in(as_job='3.0')
-    def publish(self, datasource_item, file_path, mode, as_job=False, connection_credentials=None):
+    def publish(self, datasource_item, file_path, mode, connection_credentials=None, as_job=False):
         if not os.path.isfile(file_path):
             error = "File path does not lead to an existing file."
             raise IOError(error)
@@ -175,7 +175,7 @@ def publish(self, datasource_item, file_path, mode, as_job=False, connection_cre
         if mode == self.parent_srv.PublishMode.Overwrite or mode == self.parent_srv.PublishMode.Append:
             url += '&{0}=true'.format(mode.lower())
 
-        if as_job is True:
+        if as_job:
             url += '&{0}=true'.format('asJob')
 
         # Determine if chunking is required (64MB is the limit for single upload method)
@@ -195,7 +195,7 @@ def publish(self, datasource_item, file_path, mode, as_job=False, connection_cre
                                                                               connection_credentials)
         server_response = self.post_request(url, xml_request, content_type)
 
-        if as_job is True:
+        if as_job:
             new_job = JobItem.from_response(server_response.content, self.parent_srv.namespace)[0]
             logger.info('Published {0} (JOB_ID: {1}'.format(filename, new_job.id))
             return new_job

tableauserverclient/server/endpoint/workbooks_endpoint.py

@@ -200,7 +200,7 @@ def _get_wb_preview_image(self, workbook_item):
     # Publishes workbook. Chunking method if file over 64MB
     @api(version="2.0")
     @parameter_added_in(as_job='3.0')
-    def publish(self, workbook_item, file_path, mode, as_job=False, connection_credentials=None):
+    def publish(self, workbook_item, file_path, mode, connection_credentials=None, as_job=False):
         if not os.path.isfile(file_path):
             error = "File path does not lead to an existing file."
             raise IOError(error)
@@ -226,7 +226,7 @@ def publish(self, workbook_item, file_path, mode, as_job=False, connection_crede
             error = 'Workbooks cannot be appended.'
             raise ValueError(error)
 
-        if as_job is True:
+        if as_job:
             url += '&{0}=true'.format('asJob')
 
         # Determine if chunking is required (64MB is the limit for single upload method)
@@ -245,7 +245,7 @@ def publish(self, workbook_item, file_path, mode, as_job=False, connection_crede
                                                                             file_contents,
                                                                             connection_credentials)
         server_response = self.post_request(url, xml_request, content_type)
-        if as_job is True:
+        if as_job:
             new_job = JobItem.from_response(server_response.content, self.parent_srv.namespace)[0]
             logger.info('Published {0} (JOB_ID: {1}'.format(filename, new_job.id))
             return new_job