- Fixing test asset to have real value instead of api documentation value

- Removing extra comments
- Reformatting with proper version of black

Author: casey-crawford-cfa

tableauserverclient/server/endpoint/groups_endpoint.py

@@ -173,12 +173,10 @@ def delete(self, group_id: str) -> None:
         logger.info(f"Deleted single group (ID: {group_id})")
 
     @overload
-    def update(self, group_item: GroupItem, as_job: Literal[False]) -> GroupItem:
-        ...
+    def update(self, group_item: GroupItem, as_job: Literal[False]) -> GroupItem: ...
 
     @overload
-    def update(self, group_item: GroupItem, as_job: Literal[True]) -> JobItem:
-        ...
+    def update(self, group_item: GroupItem, as_job: Literal[True]) -> JobItem: ...
 
     @api(version="2.0")
     def update(self, group_item, as_job=False):
@@ -260,12 +258,10 @@ def create(self, group_item: GroupItem) -> GroupItem:
         return GroupItem.from_response(server_response.content, self.parent_srv.namespace)[0]
 
     @overload
-    def create_AD_group(self, group_item: GroupItem, asJob: Literal[False]) -> GroupItem:
-        ...
+    def create_AD_group(self, group_item: GroupItem, asJob: Literal[False]) -> GroupItem: ...
 
     @overload
-    def create_AD_group(self, group_item: GroupItem, asJob: Literal[True]) -> JobItem:
-        ...
+    def create_AD_group(self, group_item: GroupItem, asJob: Literal[True]) -> JobItem: ...
 
     @api(version="2.0")
     def create_AD_group(self, group_item, asJob=False):

tableauserverclient/server/pager.py

@@ -12,14 +12,12 @@
 
 @runtime_checkable
 class Endpoint(Protocol[T]):
-    def get(self, req_options: Optional[RequestOptions]) -> tuple[list[T], PaginationItem]:
-        ...
+    def get(self, req_options: Optional[RequestOptions]) -> tuple[list[T], PaginationItem]: ...
 
 
 @runtime_checkable
 class CallableEndpoint(Protocol[T]):
-    def __call__(self, __req_options: Optional[RequestOptions], **kwargs) -> tuple[list[T], PaginationItem]:
-        ...
+    def __call__(self, __req_options: Optional[RequestOptions], **kwargs) -> tuple[list[T], PaginationItem]: ...
 
 
 class Pager(Iterable[T]):

tableauserverclient/server/query.py

@@ -97,12 +97,10 @@ def __iter__(self: Self) -> Iterator[T]:
                 return
 
     @overload
-    def __getitem__(self: Self, k: Slice) -> list[T]:
-        ...
+    def __getitem__(self: Self, k: Slice) -> list[T]: ...
 
     @overload
-    def __getitem__(self: Self, k: int) -> T:
-        ...
+    def __getitem__(self: Self, k: int) -> T: ...
 
     def __getitem__(self, k):
         page = self.page_number

tableauserverclient/server/request_factory.py

@@ -1008,9 +1008,9 @@ def update_req(self, workbook_item, parent_srv: Optional["Server"] = None):
             if data_freshness_policy_config.option == "FreshEvery":
                 if data_freshness_policy_config.fresh_every_schedule is not None:
                     fresh_every_element = ET.SubElement(data_freshness_policy_element, "freshEverySchedule")
-                    fresh_every_element.attrib[
-                        "frequency"
-                    ] = data_freshness_policy_config.fresh_every_schedule.frequency
+                    fresh_every_element.attrib["frequency"] = (
+                        data_freshness_policy_config.fresh_every_schedule.frequency
+                    )
                     fresh_every_element.attrib["value"] = str(data_freshness_policy_config.fresh_every_schedule.value)
                 else:
                     raise ValueError(f"data_freshness_policy_config.fresh_every_schedule must be populated.")

test/assets/schedule_get_extract_refresh_tasks.xml

@@ -3,12 +3,12 @@
   <extracts>
     <extract id="task1"
       priority="1"
-      type="incremental-or-full" >
+      type="IncrementalRefresh" >
         <workbook id="workbook-id" />
     </extract>
     <extract id="task2"
       priority="2"
-      type="incremental-or-full" >
+      type="IncrementalRefresh" >
         <datasource id="datasource-id" />
     </extract>
   </extracts>

test/test_schedule.py

@@ -414,10 +414,7 @@ def test_get_extract_refresh_tasks(self) -> None:
             response_xml = f.read().decode("utf-8")
         with requests_mock.mock() as m:
             schedule_id = "c9cff7f9-309c-4361-99ff-d4ba8c9f5467"
-            # baseurl = f"{self.baseurl}/schedules/{schedule_id}/extracts"
             baseurl = f"{self.server.baseurl}/sites/{self.server.site_id}/schedules/{schedule_id}/extracts"
-            # Fix the URL construction to match the endpoint pattern
-            # url = f"{self.baseurl}/{schedule_id}/extracts"
             m.get(baseurl, text=response_xml)
 
             extracts = self.server.schedules.get_extract_refresh_tasks(schedule_id)