Skip to content

Commit f1c9588

Browse files
committed
addressing PR comments
1 parent c1f75d9 commit f1c9588

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

samples/publish_workbook.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def main():
4444
parser.add_argument("--file", "-f", help="local filepath of the workbook to publish")
4545
parser.add_argument("--as-job", "-a", help="Publishing asynchronously", action="store_true")
4646
parser.add_argument("--skip-connection-check", "-c", help="Skip live connection check", action="store_true")
47-
parser.add_argument("--project", help="Project within which to publish the datasource")
47+
parser.add_argument("--project", help="Project within which to publish the workbook")
4848
parser.add_argument("--show-tabs", help="Publish workbooks with tabs displayed", action="store_true")
4949

5050
args = parser.parse_args()

tableauserverclient/server/request_factory.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -961,8 +961,7 @@ def _generate_xml(
961961

962962
if workbook_item.thumbnails_user_id is not None:
963963
workbook_element.attrib["thumbnailsUserId"] = workbook_item.thumbnails_user_id
964-
965-
if workbook_item.thumbnails_group_id is not None:
964+
elif workbook_item.thumbnails_group_id is not None:
966965
workbook_element.attrib["thumbnailsGroupId"] = workbook_item.thumbnails_group_id
967966

968967
return ET.tostring(xml_request)

0 commit comments

Comments
 (0)