jshint warnings

Author: achingbrain

.gitignore

@@ -2,3 +2,4 @@ node_modules
 *.iml
 .idea
 .DS_Store
+*.log

gulpfile.js

@@ -23,6 +23,7 @@ gulp.task('verify-solutions', function() {
         {cwd: __dirname + '/tests'}))
 
     .on('error', function (err) {
+      console.error(err)
       process.exit(-1)
     })
 })

nodebot-workshop.js

@@ -1,11 +1,11 @@
 #!/usr/bin/env node
 
 const workshop = require('workshopper-adventure')({
-  appDir: __dirname,
-  languages: ['en', 'ja'],
-  menu: {fg: 'black', bg: /^win/.test(process.platform) ? 'yellow' : 220},
-  header: require('workshopper-adventure/default/header'),
-  footer: require('workshopper-adventure/default/footer')
+    appDir    : __dirname
+  , languages : ['en', 'ja']
+  , menu      : {fg: 'black', bg: /^win/.test(process.platform) ? 'yellow' : 220}
+  , header    : require('workshopper-adventure/default/header')
+  , footer    : require('workshopper-adventure/default/footer')
 })
 
 workshop.addAll(require('./exercises/menu.json'))

package.json

@@ -5,7 +5,8 @@
   "main": "nodebot-workshop.js",
   "scripts": {
     "start": "./nodebot-workshop.js",
-    "test": "gulp"
+    "test": "gulp",
+    "lint": "jshint exercises tests stubs *.js"
   },
   "bin": {
     "nodebot-workshop": "./nodebot-workshop.js"
@@ -51,6 +52,10 @@
     "gulp-jshint": "^2.0.0",
     "gulp-shell": "^0.5.1",
     "jshint": "^2.8.0",
-    "jshint-stylish": "^2.1.0"
-  }
+    "jshint-stylish": "^2.1.0",
+    "pre-commit": "^1.1.2"
+  },
+  "pre-commit": [
+    "lint", "test"
+  ]
 }

stubs/io-stub.js

@@ -1,16 +1,15 @@
 var sinon = require('sinon'),
-  EventEmitter = require('events').EventEmitter,
   util = require('util'),
   IOBoard = require('ioboard');
 
 // an IO plugin for Johnny-Five that looks like an Arduino UNO
 // https://github.com/rwaldron/johnny-five/wiki/IO-Plugins
-IO = function(path, callback) {
+var IO = function(path, callback) {
   IOBoard.call(this, {quiet: true});
 
   // pretend we've connected to firmata
   setTimeout(function() {
-    this.emit("connected");
+    this.emit('connected');
 
     // would now query the board's capabilities
     setTimeout(function() {
@@ -51,7 +50,7 @@ IO = function(path, callback) {
         });
       }
 
-      this.emit("ready");
+      this.emit('ready');
 
       callback();
     }.bind(this), 200);
@@ -62,7 +61,7 @@ util.inherits(IO, IOBoard);
 module.exports = {
   Board: function(port, callback) {
     if(module.exports.singleton) {
-      throw new Error("Board already created");
+      throw new Error('Board already created');
     }
 
     var singleton = new IO(port, callback);

stubs/serialport-stub.js

@@ -1,13 +1,13 @@
 var sinon = require('sinon');
 
-SerialPort = function() {
+var SerialPort = function() {
 
 }
 
-SerialPort.list = sinon.stub();
+SerialPort.list = sinon.stub()
 SerialPort.list.callsArgWithAsync(0, null, [{
   // has to match the regex /usb|acm|^com/i
-  comName: "/dev/cu.usbserial-FAKEID"
-}]);
+  comName: '/dev/cu.usbserial-FAKEID'
+}])
 
-module.exports = sinon.spy(SerialPort);
+module.exports = sinon.spy(SerialPort)

tests/verify-solutions.js

@@ -20,27 +20,13 @@ const workshopper = require('workshopper-adventure')
   , path        = require('path')
   , fs          = require('fs')
   , menu        = require('../exercises/menu')
-  , name        = 'nodebot-workshop'
-  , title       = 'Nodebot Workshop'
-  , subtitle    = '\x1b[23mSelect an exercise and hit \x1b[3mEnter\x1b[23m to begin'
-
-function fpath (f) {
-  return path.join(__dirname, f)
-}
 
 workshopper.prototype.printMenu = function () {
   // snap it off
 }
 
 var nodebot = workshopper({
-  name        : name
-  , title       : title
-  , subtitle    : subtitle
-  , exerciseDir : fpath('../exercises/')
-  , appDir      : __dirname + '/..'
-  , helpFile    : fpath('help.txt')
-  , menuItems   : []
-  , menu        : {fg: "black", bg: 220}
+    appDir      : __dirname + '/..'
   , menuFactory: {
       options: {},
       create: function () {
@@ -60,9 +46,10 @@ function testSolution(name) {
     return name
   }
 
-  var exercise = nodebot.loadExercise(name)
+  nodebot.loadExercise(name)
 
-  var solution = path.relative(__dirname, path.join(__dirname, '..', 'exercises', workshopperUtils.dirFromName(name), 'solution', 'solution.js'))
+  var solution = path.relative(__dirname,
+    path.join(__dirname, '..', 'exercises', workshopperUtils.dirFromName(name), 'solution', 'solution.js'))
 
   nodebot.execute(['select', name])
   nodebot.execute(['verify', solution])