fix: use root cause for gix errors

Signed-off-by: 35V LG84 <35vlg84-x4e6b92@e257.fi>

Author: 35VLG84

CHANGELOG.adoc

@@ -15,8 +15,6 @@ New features:
 
 Changed functionality:
 
-* git-subsystem: some error messages are different
-  ** link:https://github.com/GitoxideLabs/gitoxide/issues/2351[gitoxide #2351]
 * ...
   ** ...
 

tackler-core/src/parser/tackler_txns.rs

@@ -4,6 +4,7 @@
  */
 use itertools::Itertools;
 use std::collections::HashSet;
+use std::error::Error;
 use std::path::{Path, PathBuf};
 use std::str;
 //use std::time::{SystemTime, UNIX_EPOCH};
@@ -84,7 +85,18 @@ pub fn git_to_txns(
             (repo.find_object(object_id)?.try_into_commit()?, None)
         }
         GitInputSelector::Reference(ref_str) => {
-            let id = repo.rev_parse_single(ref_str.as_bytes())?;
+            let id_res = repo.rev_parse_single(ref_str.as_bytes());
+            let id = match id_res {
+                Ok(id) => id,
+                Err(err) => {
+                    let msg = if let Some(source) = err.source() {
+                        format!("{source}")
+                    } else {
+                        format!("{err}")
+                    };
+                    return Err(msg.into());
+                }
+            };
             let reference = if id.to_string().starts_with(ref_str.as_str()) {
                 // This is tackler specific logic: don't show ref if it's plain commit id
                 None

tests/sh/core-git-errors.sh

@@ -61,18 +61,29 @@ echo "check: ok"
 
 #####################################################################
 #
-# todo: GitoxideLabs/gitoxide#2351
-# 2>&1 | grep 'Tackler error: Txn Data: .* object .* ef8845.* could not be found'
-#
 # test: c233295d-08b9-49b5-b384-634fc8432e64
-# desc: commit not found
-test_name=git-unknown-commit
+# desc: commit not found (by ref)
+test_name=git-unknown-commit-by-ref
 echo "test: $module/$test_name: $mode"
 
 $TACKLER_SH \
     --config $SUITE_PATH/$module/git-ok.toml \
     --input.git.ref ef88456ffae9eb546d115833f2ad66d48a8e268b \
-    2>&1 | grep 'Tackler error: Txn Data: .* ef8845.*'
+    2>&1 | grep 'Tackler error: Txn Data: .* object .* ef8845.* could not be found'
+
+echo "check: ok"
+
+#####################################################################
+#
+# test: beed0077-33b6-441f-b7be-deca8080362d
+# desc: commit not found (by commit)
+test_name=git-unknown-commit-by-commit
+echo "test: $module/$test_name: $mode"
+
+$TACKLER_SH \
+    --config $SUITE_PATH/$module/git-ok.toml \
+    --input.git.commit ef88456ffae9eb546d115833f2ad66d48a8e268b \
+    2>&1 | grep "Tackler error: Txn Data: Unknown commit id 'ef88456ffae9eb546d115833f2ad66d48a8e268b'"
 
 echo "check: ok"
 
@@ -86,15 +97,15 @@ echo "test: $module/$test_name: $mode"
 $TACKLER_SH \
     --config $SUITE_PATH/$module/git-ok.toml \
     --input.git.ref "//" \
-    2>&1 | grep "couldn't parse revision: //"
+    2>&1 | grep 'An error occurred while trying to find a reference'
 
 echo "check: ok"
 
 #####################################################################
 #
 # test: 7cb6af2e-3061-4867-96e3-ee175b87a114
 # desc: can not resolve ref
-test_name=git-ref-dosnt-resolve
+test_name=git-ref-doesnt-resolve
 echo "test: $module/$test_name: $mode"
 
 $TACKLER_SH \
@@ -106,9 +117,6 @@ echo "check: ok"
 
 #####################################################################
 #
-# todo: GitoxideLabs/gitoxide#2351
-# 2>&1 | grep 'Tackler error: Txn Data: The ref .* "not-found-ref" .* not be found'
-#
 # test: 4b507e08-b90e-4a6f-9c6b-4fef7c58d9fe
 # desc: ref which is not found
 test_name=git-ref-not-found
@@ -117,15 +125,12 @@ echo "test: $module/$test_name: $mode"
 $TACKLER_SH \
     --config $SUITE_PATH/$module/git-ok.toml \
     --input.git.ref "not-found-ref" \
-    2>&1 | grep 'Tackler error: Txn Data: .*not-found-ref'
+    2>&1 | grep 'Tackler error: Txn Data: The ref .* "not-found-ref" .* not be found'
 
 echo "check: ok"
 
 #####################################################################
 #
-# todo: GitoxideLabs/gitoxide#2351
-# 2>&1 | grep 'Tackler error: Txn Data: Tried to navigate .* anchor first'
-#
 # test: 14b7e8eb-d168-48b2-86e7-8d922f306ad0
 # desc: ref format is invalid
 test_name=invalid-ref-format
@@ -136,7 +141,7 @@ $TACKLER_SH \
     --output.prefix $test_name \
     --config $SUITE_PATH/$module/git-ok.toml \
     --input.git.ref "^^^" \
-    2>&1 | grep 'Tackler error: .*\^'
+    2>&1 | grep 'Tackler error: Txn Data: Tried to navigate .* anchor first'
 
 echo "check: ok"