refactor(benches): optimize NFT send (#3278)

Author: i582

src/benchmarks/nft/results_code_size.json

@@ -189,6 +189,16 @@
         "item cells": "10",
         "item bits": "5393"
       }
+    },
+    {
+      "label": "1.6.11 with optimized send",
+      "pr": null,
+      "size": {
+        "collection cells": "39",
+        "collection bits": "19604",
+        "item cells": "10",
+        "item bits": "5217"
+      }
     }
   ]
 }

src/benchmarks/nft/results_gas.json

@@ -179,6 +179,16 @@
         "deploy nft": "10520",
         "batch deploy nft": "654138"
       }
+    },
+    {
+      "label": "1.6.11 with optimized send",
+      "pr": null,
+      "gas": {
+        "transfer": "6979",
+        "get static data": "4424",
+        "deploy nft": "10335",
+        "batch deploy nft": "654266"
+      }
     }
   ]
 }

src/benchmarks/nft/tact/collection.tact

@@ -2,23 +2,6 @@ import "./constants";
 import "./messages";
 import "./item";
 
-struct DictGet {
-    itemIndex: Int? as uint64; // IndexSizeBits = 64
-    item: Slice?;
-    flag: Int;
-}
-
-struct DictItem {
-    amount: Int as coins;
-    initNFTBody: Cell;
-}
-
-// (int, slice, int) udict_get_min?(cell dict, int key_len) asm (-> 1 0 2) "DICTUMIN" "NULLSWAPIFNOT2";
-asm(-> 1 0 2) fun dictGetMin(dict: Cell, keySize: Int): DictGet { DICTUMIN NULLSWAPIFNOT2 }
-
-// (int, slice, int) udict_get_next?(cell dict, int key_len, int pivot) asm(pivot dict key_len -> 1 0 2) "DICTUGETNEXT" "NULLSWAPIFNOT2";
-asm(-> 1 0 2) fun dictGetNext(pivot: Int, dict: Cell, keySize: Int): DictGet { DICTUGETNEXT NULLSWAPIFNOT2 }
-
 contract NFTCollection {
     owner: Address;
     nextItemIndex: Int as uint64; // IndexSizeBits = 64
@@ -42,6 +25,17 @@ contract NFTCollection {
 
     receive() {} // ignore empty messages
 
+    receive(msg: DeployNFT) {
+        throwUnless(IncorrectSender, sender() == self.owner);
+        throwUnless(IncorrectIndex, msg.itemIndex <= self.nextItemIndex);
+
+        deployNFTItem(self.commonCode, msg.itemIndex, msg.amount, msg.initNFTBody, self.commonData);
+
+        if (msg.itemIndex == self.nextItemIndex) {
+            self.nextItemIndex += 1;
+        }
+    }
+
     receive(msg: GetRoyaltyParams) {
         message(MessageParameters {
             bounce: false,
@@ -55,17 +49,6 @@ contract NFTCollection {
         });
     }
 
-    receive(msg: DeployNFT) {
-        throwUnless(IncorrectSender, sender() == self.owner);
-        throwUnless(IncorrectIndex, msg.itemIndex <= self.nextItemIndex);
-
-        deployNFTItem(self.commonCode, msg.itemIndex, msg.amount, msg.initNFTBody, self.commonData);
-
-        if (msg.itemIndex == self.nextItemIndex) {
-            self.nextItemIndex += 1;
-        }
-    }
-
     receive(msg: BatchDeploy) {
         throwUnless(IncorrectSender, sender() == self.owner);
 
@@ -136,3 +119,20 @@ inline fun deployNFTItem(commonCode: Cell, itemIndex: Int, amount: Int, initNFTB
         mode: SendPayFwdFeesSeparately,
     });
 }
+
+struct DictGet {
+    itemIndex: Int? as uint64; // IndexSizeBits = 64
+    item: Slice?;
+    flag: Int;
+}
+
+struct DictItem {
+    amount: Int as coins;
+    initNFTBody: Cell;
+}
+
+// (int, slice, int) udict_get_min?(cell dict, int key_len) asm (-> 1 0 2) "DICTUMIN" "NULLSWAPIFNOT2";
+asm(-> 1 0 2) fun dictGetMin(dict: Cell, keySize: Int): DictGet { DICTUMIN NULLSWAPIFNOT2 }
+
+// (int, slice, int) udict_get_next?(cell dict, int key_len, int pivot) asm(pivot dict key_len -> 1 0 2) "DICTUGETNEXT" "NULLSWAPIFNOT2";
+asm(-> 1 0 2) fun dictGetNext(pivot: Int, dict: Cell, keySize: Int): DictGet { DICTUGETNEXT NULLSWAPIFNOT2 }

src/benchmarks/nft/tact/item.tact

@@ -1,22 +1,6 @@
 import "./constants";
 import "./messages";
 
-inline fun sendMsg(toAddress: Address, amount: Int, op: Int, queryId: Int, payload: Builder, sendMode: Int) {
-    let msgBody = beginCell().storeUint(op, 32).storeUint(queryId, 64);
-
-    if (payload.bits() != 0) {
-        msgBody = msgBody.storeBuilder(payload);
-    }
-
-    message(MessageParameters {
-        bounce: false,
-        to: toAddress,
-        value: amount,
-        body: msgBody.endCell(),
-        mode: sendMode,
-    });
-}
-
 struct NFTItemInit {
     owner: Address;
     content: Cell;
@@ -28,7 +12,22 @@ contract NFTItem(
     collectionAddress: Address,
     itemIndex: Int as uint64,
 ) {
-    receive() {} //to ignore empty messages
+    receive() {} // ignore empty messages
+
+    receive(msg: GetStaticData) {
+        throwUnless(NotInit, self.owner != null);
+
+        sendMsg(
+            sender(),
+            0,
+            ReportStaticData,
+            msg.queryId,
+            beginCell()
+                .storeUint(self.itemIndex, 256)
+                .storeAddress(self.collectionAddress),
+            SendRemainingValue,
+        ); // implementation detail
+    }
 
     receive(msg: Slice) {
         // Check if owner == null, which means the contract hasn't been initialized yet
@@ -52,35 +51,47 @@ contract NFTItem(
         throwUnless(IncorrectForwardPayload, msg.forwardPayload.bits() >= 1);
         forceBasechain(msg.newOwner);
 
-        let fwdFees: Int = context().readForwardFee();
+        let fwdFees = context().readForwardFee();
 
-        let restAmount: Int = myBalance() - minTonsForStorage;
+        let restAmount = myBalance() - minTonsForStorage;
         if (msg.forwardAmount > 0) {
-            restAmount -= (msg.forwardAmount + fwdFees);
+            restAmount -= msg.forwardAmount + fwdFees;
         }
 
         // when we load addr_none$00 in tact we got null
-        let needResponse: Bool = (msg.responseDestination != null);
+        let needResponse = msg.responseDestination != null;
         if (needResponse) {
             restAmount -= fwdFees;
         }
 
         throwUnless(InvalidFees, restAmount >= 0);
 
         if (msg.forwardAmount > 0) {
-            sendMsg(msg.newOwner, msg.forwardAmount, OwnershipAssigned, msg.queryId, beginCell().storeAddress(self.owner!!).storeSlice(msg.forwardPayload), SendPayFwdFeesSeparately);
+            sendMsg(
+                msg.newOwner,
+                msg.forwardAmount,
+                OwnershipAssigned,
+                msg.queryId,
+                beginCell()
+                    .storeAddress(self.owner!!)
+                    .storeSlice(msg.forwardPayload),
+                SendPayFwdFeesSeparately,
+            );
         }
+
         if (needResponse) {
             forceBasechain(msg.responseDestination!!);
-            sendMsg(msg.responseDestination!!, restAmount, Excesses, msg.queryId, beginCell(), SendPayFwdFeesSeparately);
+            sendMsg(
+                msg.responseDestination!!,
+                restAmount,
+                Excesses,
+                msg.queryId,
+                beginCell(),
+                SendPayFwdFeesSeparately,
+            );
         }
-        self.owner = msg.newOwner;
-    }
-
-    receive(msg: GetStaticData) {
-        throwUnless(NotInit, self.owner != null);
 
-        sendMsg(sender(), 0, ReportStaticData, msg.queryId, beginCell().storeUint(self.itemIndex, 256).storeAddress(self.collectionAddress), SendRemainingValue); // implementation detail
+        self.owner = msg.newOwner;
     }
 
     get fun get_nft_data(): NFTData {
@@ -93,3 +104,17 @@ contract NFTItem(
         };
     }
 }
+
+inline fun sendMsg(toAddress: Address, amount: Int, op: Int, queryId: Int, payload: Builder, sendMode: Int) {
+    message(MessageParameters {
+        bounce: false,
+        to: toAddress,
+        value: amount,
+        body: beginCell()
+            .storeUint(op, 32)
+            .storeUint(queryId, 64)
+            .storeBuilder(payload)
+            .endCell(),
+        mode: sendMode,
+    });
+}