Squash one could-be-used-uninitialized warning

jcflack · jcflack · commit fe6e7da08179 · 2025-05-30T18:46:01.000-04:00
Interesting that Mac OS clang was the only compiler to spot it.
diff --git a/pljava-so/src/main/c/ModelUtils.c b/pljava-so/src/main/c/ModelUtils.c
@@ -1223,7 +1223,7 @@ Java_org_postgresql_pljava_pg_LookupImpl__1cacheReference(JNIEnv* env, jobject _
 JNIEXPORT jboolean JNICALL
 Java_org_postgresql_pljava_pg_LookupImpl__1get_1fn_1expr_1variadic(JNIEnv* env, jobject _cls, jobject fcinfo_b)
 {
-	bool result;
+	bool result = false;
 	FunctionCallInfo fcinfo = (*env)->GetDirectBufferAddress(env, fcinfo_b);
 	if ( NULL == fcinfo )
 		return JNI_FALSE; /* shouldn't happen; there's probably an exception */

Original file line number	Diff line number	Diff line change
`@@ -1223,7 +1223,7 @@ Java_org_postgresql_pljava_pg_LookupImpl__1cacheReference(JNIEnv* env, jobject _`
`1223`	`1223`	`JNIEXPORT jboolean JNICALL`
`1224`	`1224`	`Java_org_postgresql_pljava_pg_LookupImpl__1get_1fn_1expr_1variadic(JNIEnv* env, jobject _cls, jobject fcinfo_b)`
`1225`	`1225`	`{`
`1226`		`- bool result;`
	`1226`	`+ bool result = false;`
`1227`	`1227`	`FunctionCallInfo fcinfo = (*env)->GetDirectBufferAddress(env, fcinfo_b);`
`1228`	`1228`	`if ( NULL == fcinfo )`
`1229`	`1229`	`return JNI_FALSE; /* shouldn't happen; there's probably an exception */`