fix tests

Author: shahar4499

tests/fixtures/simple_app.py

@@ -25,23 +25,23 @@ async def list_items(
         skip: int = Query(0, description="Number of items to skip"),
         limit: int = Query(10, description="Max number of items to return"),
         sort_by: Optional[str] = Query(None, description="Field to sort by"),
-    ):
+    ) -> List[Item]:
         """List all items with pagination and sorting options."""
         return items[skip : skip + limit]
 
     @app.get("/items/{item_id}", response_model=Item, tags=["items"], operation_id="get_item")
     async def read_item(
         item_id: int = Path(..., description="The ID of the item to retrieve"),
         include_details: bool = Query(False, description="Include additional details"),
-    ):
+    ) -> Item:
         """Get a specific item by its ID with optional details."""
         found_item = next((item for item in items if item.id == item_id), None)
         if found_item is None:
             raise HTTPException(status_code=404, detail="Item not found")
         return found_item
 
     @app.post("/items/", response_model=Item, tags=["items"], operation_id="create_item")
-    async def create_item(item: Item = Body(..., description="The item to create")):
+    async def create_item(item: Item = Body(..., description="The item to create")) -> Item:
         """Create a new item in the database."""
         items.append(item)
         return item
@@ -50,18 +50,18 @@ async def create_item(item: Item = Body(..., description="The item to create")):
     async def update_item(
         item_id: int = Path(..., description="The ID of the item to update"),
         item: Item = Body(..., description="The updated item data"),
-    ):
+    ) -> Item:
         """Update an existing item."""
         item.id = item_id
         return item
 
     @app.delete("/items/{item_id}", status_code=204, tags=["items"], operation_id="delete_item")
-    async def delete_item(item_id: int = Path(..., description="The ID of the item to delete")):
+    async def delete_item(item_id: int = Path(..., description="The ID of the item to delete")) -> None:
         """Delete an item from the database."""
         return None
 
-    @app.get("/error", status_code=200, tags=["error"], operation_id="raise_error")
-    async def raise_error():
+    @app.get("/error", tags=["error"], operation_id="raise_error")
+    async def raise_error() -> None:
         """Fail on purpose and cause a 500 error."""
         raise Exception("This is a test error")
 

tests/test_basic_functionality.py

@@ -22,7 +22,7 @@ def test_create_mcp_server(simple_fastapi_app: FastAPI):
     assert len(mcp.operation_map) > 0, "Should have operation mapping"
 
     # Check that the operation map contains all expected operations from simple_app
-    expected_operations = ["list_items", "get_item", "create_item", "update_item", "delete_item"]
+    expected_operations = ["list_items", "get_item", "create_item", "update_item", "delete_item", "raise_error"]
     for op in expected_operations:
         assert op in mcp.operation_map, f"Operation {op} not found in operation map"
 

tests/test_configuration.py

@@ -81,7 +81,9 @@ def test_describe_all_responses_config_simple_app(simple_fastapi_app: FastAPI):
 
     for tool in mcp_default.tools:
         assert tool.description is not None
-        if tool.name != "delete_item":
+        if tool.name == "raise_error":
+            pass
+        elif tool.name != "delete_item":
             assert tool.description.count("**200**") == 1, "The description should contain a 200 status code"
             assert tool.description.count("**Example Response:**") == 1, (
                 "The description should only contain one example response"
@@ -103,7 +105,9 @@ def test_describe_all_responses_config_simple_app(simple_fastapi_app: FastAPI):
 
     for tool in mcp_all_responses.tools:
         assert tool.description is not None
-        if tool.name != "delete_item":
+        if tool.name == "raise_error":
+            pass
+        elif tool.name != "delete_item":
             assert tool.description.count("**200**") == 1, "The description should contain a 200 status code"
             assert tool.description.count("**422**") == 1, "The description should contain a 422 status code"
             assert tool.description.count("**Example Response:**") == 2, (
@@ -137,7 +141,9 @@ def test_describe_full_response_schema_config_simple_app(simple_fastapi_app: Fas
 
     for tool in mcp_full_response_schema.tools:
         assert tool.description is not None
-        if tool.name != "delete_item":
+        if tool.name == "raise_error":
+            pass
+        elif tool.name != "delete_item":
             assert tool.description.count("**200**") == 1, "The description should contain a 200 status code"
             assert tool.description.count("**Example Response:**") == 1, (
                 "The description should only contain one example response"
@@ -170,7 +176,9 @@ def test_describe_all_responses_and_full_response_schema_config_simple_app(simpl
 
     for tool in mcp_all_responses_and_full_response_schema.tools:
         assert tool.description is not None
-        if tool.name != "delete_item":
+        if tool.name == "raise_error":
+            pass
+        elif tool.name != "delete_item":
             assert tool.description.count("**200**") == 1, "The description should contain a 200 status code"
             assert tool.description.count("**422**") == 1, "The description should contain a 422 status code"
             assert tool.description.count("**Example Response:**") == 2, (