Skip to content

Commit 8644cea

Browse files
committed
Make modules reader and writer public
All examples updated to use more explicit names
1 parent bc0dbd2 commit 8644cea

25 files changed

+65
-50
lines changed

Changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,9 @@
188188

189189
- [#455]: Removed `Reader::read_text_into` which is only not a better wrapper over match on `Event::Text`
190190

191+
- [#456]: Reader and writer stuff grouped under `reader` and `writer` modules.
192+
You still can use re-exported definitions from a crate root
193+
191194
### New Tests
192195

193196
- [#9]: Added tests for incorrect nested tags in input
@@ -230,6 +233,7 @@
230233
[#445]: https://github.com/tafia/quick-xml/pull/445
231234
[#450]: https://github.com/tafia/quick-xml/pull/450
232235
[#455]: https://github.com/tafia/quick-xml/pull/455
236+
[#456]: https://github.com/tafia/quick-xml/pull/456
233237

234238

235239
## 0.23.0 -- 2022-05-08

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ Syntax is inspired by [xml-rs](https://github.com/netvl/xml-rs).
1919
### Reader
2020

2121
```rust
22-
use quick_xml::Reader;
2322
use quick_xml::events::Event;
23+
use quick_xml::reader::Reader;
2424

2525
let xml = r#"<tag1 att1 = "test">
2626
<tag2><!--Test comment-->Test</tag2>
@@ -66,7 +66,8 @@ loop {
6666

6767
```rust
6868
use quick_xml::events::{Event, BytesEnd, BytesStart};
69-
use quick_xml::{Reader, Writer};
69+
use quick_xml::reader::Reader;
70+
use quick_xml::writer::Writer;
7071
use std::io::Cursor;
7172

7273
let xml = r#"<this_tag k1="v1" k2="v2"><child>text</child></this_tag>"#;

benches/macrobenches.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use criterion::{self, criterion_group, criterion_main, Criterion, Throughput};
22
use quick_xml::events::Event;
3+
use quick_xml::reader::{NsReader, Reader};
34
use quick_xml::Result as XmlResult;
4-
use quick_xml::{NsReader, Reader};
55

66
static RPM_PRIMARY: &str = include_str!("../tests/documents/rpm_primary.xml");
77
static RPM_PRIMARY2: &str = include_str!("../tests/documents/rpm_primary2.xml");

benches/microbenches.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use pretty_assertions::assert_eq;
33
use quick_xml::escape::{escape, unescape};
44
use quick_xml::events::Event;
55
use quick_xml::name::QName;
6-
use quick_xml::{NsReader, Reader};
6+
use quick_xml::reader::{NsReader, Reader};
77

88
static SAMPLE: &str = include_str!("../tests/documents/sample_rss.xml");
99
static PLAYERS: &str = include_str!("../tests/documents/players.xml");

compare/benches/bench.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
use criterion::{self, criterion_group, criterion_main, BenchmarkId, Criterion, Throughput};
22
use pretty_assertions::assert_eq;
3-
use quick_xml::{self, events::Event, Reader};
3+
use quick_xml::events::Event;
4+
use quick_xml::reader::Reader;
45
use serde::Deserialize;
56
use serde_xml_rs;
67
use xml::reader::{EventReader, XmlEvent};

examples/custom_entities.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
use std::collections::HashMap;
1111

1212
use quick_xml::events::Event;
13-
use quick_xml::Reader;
13+
use quick_xml::reader::Reader;
1414
use regex::bytes::Regex;
1515

1616
const DATA: &str = r#"

examples/nested_readers.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use pretty_assertions::assert_eq;
22
use quick_xml::events::Event;
3-
use quick_xml::Reader;
3+
use quick_xml::reader::Reader;
44

55
// a structure to capture the rows we've extracted
66
// from a ECMA-376 table in document.xml

examples/read_buffered.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
fn main() -> Result<(), quick_xml::Error> {
77
use quick_xml::events::Event;
8-
use quick_xml::Reader;
8+
use quick_xml::reader::Reader;
99

1010
let mut reader = Reader::from_file("tests/documents/document.xml")?;
1111
reader.trim_text(true);

examples/read_texts.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
fn main() {
22
use quick_xml::events::Event;
3-
use quick_xml::Reader;
3+
use quick_xml::reader::Reader;
44

55
let xml = "<tag1>text1</tag1><tag1>text2</tag1>\
66
<tag1>text3</tag1><tag1><tag2>text4</tag2></tag1>";

fuzz/fuzz_targets/fuzz_target_1.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
#![no_main]
22
#[macro_use] extern crate libfuzzer_sys;
33

4-
use quick_xml::Reader;
54
use quick_xml::events::Event;
5+
use quick_xml::reader::Reader;
66
use std::io::Cursor;
77

88
fuzz_target!(|data: &[u8]| {

0 commit comments

Comments
 (0)