Merge branch 'PHP-8.3' into PHP-8.4

iluuu1994 · iluuu1994 · commit 2a74729d923d · 2025-10-02T00:44:37.000+02:00
* PHP-8.3:
  Fix broken build on *BSD with MSAN
diff --git a/NEWS b/NEWS
@@ -14,6 +14,7 @@ PHP                                                                        NEWS
     array). (ilutov)
   . Fixed bug GH-19480 (error_log php.ini cannot be unset when open_basedir is
     configured). (nielsdos)
+  . Fixed bug GH-20002 (Broken build on *BSD with MSAN). (outtersg)
 
 - Curl:
   . Fix cloning of CURLOPT_POSTFIELDS when using the clone operator instead
diff --git a/Zend/zend_string.c b/Zend/zend_string.c
@@ -505,8 +505,10 @@ ZEND_API zend_string *zend_string_concat3(
 	return res;
 }
 
-/* strlcpy and strlcat are not intercepted by msan, so we need to do it ourselves. */
-#if __has_feature(memory_sanitizer)
+/* strlcpy and strlcat are not always intercepted by msan, so we need to do it
+ * ourselves. Apply a simple heuristic to determine the platforms that need it.
+ * See https://github.com/php/php-src/issues/20002. */
+#if __has_feature(memory_sanitizer) && !defined(__FreeBSD__) && !defined(__NetBSD__) && !defined(__APPLE__)
 static size_t (*libc_strlcpy)(char *__restrict, const char *__restrict, size_t);
 size_t strlcpy(char *__restrict dest, const char *__restrict src, size_t n)
 {

Original file line number	Diff line number	Diff line change
`@@ -505,8 +505,10 @@ ZEND_API zend_string *zend_string_concat3(`
`505`	`505`	`return res;`
`506`	`506`	`}`
`507`	`507`
`508`		`-/* strlcpy and strlcat are not intercepted by msan, so we need to do it ourselves. */`
`509`		`-#if __has_feature(memory_sanitizer)`
	`508`	`+/* strlcpy and strlcat are not always intercepted by msan, so we need to do it`
	`509`	`+ * ourselves. Apply a simple heuristic to determine the platforms that need it.`
	`510`	`+ * See https://github.com/php/php-src/issues/20002. */`
	`511`	`+#if __has_feature(memory_sanitizer) && !defined(__FreeBSD__) && !defined(__NetBSD__) && !defined(__APPLE__)`
`510`	`512`	`static size_t (libc_strlcpy)(char __restrict, const char *__restrict, size_t);`
`511`	`513`	`size_t strlcpy(char __restrict dest, const char __restrict src, size_t n)`
`512`	`514`	`{`