Fix phpGH-20009: XMLReader leak on RelaxNG schema failure

ndossche · ndossche · commit c617afd6d6e4 · 2025-09-30T18:06:35.000+02:00
Closes phpGH-20014.
diff --git a/NEWS b/NEWS
@@ -48,6 +48,9 @@ PHP                                                                        NEWS
   . Fixed bug GH-19801 (leaks in var_dump() and debug_zval_dump()).
     (alexandre-daubois)
 
+- XMLReader:
+  . Fixed bug GH-20009 (XMLReader leak on RelaxNG schema failure). (nielsdos)
+
 - Zip:
   . Fixed bug GH-19688 (Remove pattern overflow in zip addGlob()). (nielsdos)
   . Fixed bug GH-19932 (Memory leak in zip setEncryptionName()/setEncryptionIndex()).
diff --git a/ext/xmlreader/php_xmlreader.c b/ext/xmlreader/php_xmlreader.c
@@ -508,6 +508,7 @@ static void php_xmlreader_set_relaxng_schema(INTERNAL_FUNCTION_PARAMETERS, int t
 
 			RETURN_TRUE;
 		} else {
+			xmlRelaxNGFree(schema);
 			php_error_docref(NULL, E_WARNING, "Schema contains errors");
 			RETURN_FALSE;
 		}

Original file line number	Diff line number	Diff line change
`@@ -508,6 +508,7 @@ static void php_xmlreader_set_relaxng_schema(INTERNAL_FUNCTION_PARAMETERS, int t`
`508`	`508`
`509`	`509`	`RETURN_TRUE;`
`510`	`510`	`} else {`
	`511`	`+ xmlRelaxNGFree(schema);`
`511`	`512`	`php_error_docref(NULL, E_WARNING, "Schema contains errors");`
`512`	`513`	`RETURN_FALSE;`
`513`	`514`	`}`