Skip to content

Commit 3031745

Browse files
committed
Move feature into a src directory
If I set base-path-to-features to ".", the workflow passes validation for "tailscale/devcontainer-feature.json" but fails because it expects a devcontainer-feature.json in every possible path: ``` Error: (!) ERR: devcontainer-feature.json not found at path 'LICENSE/devcontainer-feature.json'. Error: (!) ERR: devcontainer-feature.json not found at path 'README.md/devcontainer-feature.json'. Error: (!) ERR: devcontainer-feature.json not found at path 'codespace.jpg/devcontainer-feature.json'. ``` If I do not set base-path-to-features, the workflow fails because scandir fails: ``` Validating Feature metadata... node:internal/process/promises:246 triggerUncaughtException(err, true /* fromPromise */); ^ [Error: ENOENT: no such file or directory, scandir ''] { errno: -2, code: 'ENOENT', syscall: 'scandir', path: '' } ``` I note that all existing devcontainer features I can find follow the example of https://github.com/devcontainers/feature-starter and put their code into a src directory, and maybe that is the only way the publish workflow was tested. Try that. Signed-off-by: Denton Gentry <[email protected]>
1 parent 6737a8a commit 3031745

File tree

4 files changed

+1
-0
lines changed

4 files changed

+1
-0
lines changed

.github/workflows/release.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ jobs:
1111
uses: devcontainers/action@v1
1212
with:
1313
publish-features: "true"
14+
base-path-to-features: "./src"
1415
env:
1516
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1617
permissions:
File renamed without changes.

0 commit comments

Comments
 (0)