Skip to content

Commit 843e615

Browse files
mhofstetterwillnorris
authored andcommitted
remove unused disabled input fields in form
The detail page of a link only displays the form if the link is editable for the logged in user. Therefore, it's not necessary to disable the input fields within the form if the link isn't editable. Signed-off-by: Marco Hofstetter <[email protected]>
1 parent e6a9c75 commit 843e615

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tmpl/detail.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,17 @@ <h2 class="text-xl font-bold pb-2">Link Details</h2>
66
<div class="flex flex-wrap">
77
<div class="flex">
88
<label for=short class="flex my-2 px-2 items-center bg-gray-100 border border-r-0 border-gray-300 rounded-l-md text-gray-700">http://go/</label>
9-
<input id=short name=short required type=text size=15 placeholder="shortname" value="{{.Link.Short}}"{{if not .Editable}} disabled{{end}} pattern="\w[\w\-\.]*" title="Must start with letter or number; may contain letters, numbers, dashes, and periods."
9+
<input id=short name=short required type=text size=15 placeholder="shortname" value="{{.Link.Short}}" pattern="\w[\w\-\.]*" title="Must start with letter or number; may contain letters, numbers, dashes, and periods."
1010
class="p-2 my-2 rounded-r-md border-gray-300 placeholder:text-gray-400 disabled:bg-gray-100">
1111
<span class="flex m-2 items-center">&rarr;</span>
1212
</div>
13-
<input name=long required type=text size=40 placeholder="https://destination-url" value="{{.Link.Long}}"{{if not .Editable}} disabled{{end}} class="p-2 my-2 mr-2 max-w-full rounded-md border-gray-300 placeholder:text-gray-400 disabled:bg-gray-100">
13+
<input name=long required type=text size=40 placeholder="https://destination-url" value="{{.Link.Long}}" class="p-2 my-2 mr-2 max-w-full rounded-md border-gray-300 placeholder:text-gray-400 disabled:bg-gray-100">
1414
</div>
1515

1616
<p class="text-sm text-gray-500"><a class="text-blue-600 hover:underline" href="/.help">Help and advanced options</a></p>
1717

1818
<label for=owner class="text-sm font-bold block mt-4">Owner</label>
19-
<input id=owner name=owner required type=text size=25 placeholder="Owner" value="{{.Link.Owner}}"{{if not .Editable}} disabled{{end}} class="p-2 rounded-md border-gray-300 placeholder:text-gray-400 disabled:bg-gray-100">
19+
<input id=owner name=owner required type=text size=25 placeholder="Owner" value="{{.Link.Owner}}" class="p-2 rounded-md border-gray-300 placeholder:text-gray-400 disabled:bg-gray-100">
2020

2121
<dl>
2222
<dt class="text-sm font-bold mt-6">Date Created</dt>

0 commit comments

Comments
 (0)