golink: replace xsrftoken with Sec-Fetch-Site validation #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the use of xsrftokens entirely and replace them with requiring clients to send [Sec-Fetch-Site](https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Sec-Fetch-Site) fetch metadata request headers that clarify the relationship between the initating and requested origin. Add tests for Sec-Golink behavior which continues to be permitted as a substitute for the new CSRF protection as was for the previous one. Signed-off-by: Patrick O'Doherty <[email protected]>
patrickod
force-pushed
the
patrickod/sec-fetch-site
branch
from
37f8bb1 to
676a032
Compare
willnorris
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
maybe add Updates #NNN (or probably even Fixes #NNN) for the three open xsrf issues? https://github.com/tailscale/golink/issues?q=is%3Aissue%20state%3Aopen%20xsrf
|
CI for Nix failed |
willnorris
added a commit
that referenced
this pull request
Apr 23, 2025
As of #177, we are now using Sec-Fetch-Site instead of xsrf tokens. Updates #178 Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <[email protected]>
willnorris
added a commit
that referenced
this pull request
Apr 23, 2025
As of #177, we are now using Sec-Fetch-Site instead of xsrf tokens. Updates #178 Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <[email protected]>
willnorris
added a commit
that referenced
this pull request
Apr 23, 2025
As of #177, we are now using Sec-Fetch-Site instead of xsrf tokens. Updates #178 Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <[email protected]>
willnorris
added a commit
that referenced
this pull request
Apr 25, 2025
Prior to #177, our XSRF tokens were bound to link IDs, with a special `.new` value used for newly created links. So if a user tried to create a link that already existed, the XSRF check would fail. After #177, this now silently allows the user to overwrite the existing link without any indication that this happened. This change adds a hidden `update` param to the details edit form that must be present when updating an existing link. Updates #177 Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <[email protected]>
willnorris
added a commit
that referenced
this pull request
Apr 25, 2025
Prior to #177, our XSRF tokens were bound to link IDs, with a special `.new` value used for newly created links. So if a user tried to create a link that already existed, the XSRF check would fail. After #177, this now silently allows the user to overwrite the existing link without any indication that this happened. This change adds a hidden `update` param to the details edit form that must be present when updating an existing link. Updates #177 Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d Signed-off-by: Will Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the use of xsrftokens entirely and replace them with requiring clients to send Sec-Fetch-Site fetch metadata request headers that clarify the relationship between the initating and requested origin.
Add tests for
Sec-Golinkheader behavior which continues to be permitted as a substitute for the new CSRF protection as was for the previous one.Fixes #160
Fixes #156
Fixes #130