Skip to content

Conversation

@j-mcfadden
Copy link
Contributor

This will now load the total count of unique links from the DB & removes the ability to count an entry as new when it was only modified

@mikeodr
Copy link
Contributor

mikeodr commented Sep 11, 2025

This LGTM, but it's merging into the PR branch instead of main?

Do you want to just rebase it all to main and commit it as one item?

@j-mcfadden j-mcfadden changed the base branch from pr195 to main September 11, 2025 13:48
Copy link
Member

@willnorris willnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good... I guess I made thing more confusing by pulling thing into a new PR. Looks like it all got sorted now!

Copy link
Contributor

@mikeodr mikeodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@willnorris willnorris merged commit e33c1c2 into tailscale:main Sep 11, 2025
2 checks passed
@willnorris
Copy link
Member

shoot! meant to collapse those commits. oh well :(

@j-mcfadden j-mcfadden deleted the pr195 branch September 11, 2025 17:43
@j-mcfadden
Copy link
Contributor Author

Awesome thanks for taking a look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants