Skip to content

Commit f90967e

Browse files
authored
Makefile: run version before attempting to build the apk/aab (#566)
Makefile: run version before any APK builds updates tailscle/corp#24686 We must ensure the correct version file exists before kicking off any of the apk or aab builds. This also revs the docker image so we're picking up the latest toolchain. Signed-off-by: Jonathan Nobels <[email protected]>
1 parent 1538163 commit f90967e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# with this name, it will be used.
1111
#
1212
# The convention here is tailscale-android-build-amd64-<date>
13-
DOCKER_IMAGE=tailscale-android-build-amd64-120924
13+
DOCKER_IMAGE=tailscale-android-build-amd64-191124
1414
export TS_USE_TOOLCHAIN=1
1515

1616
DEBUG_APK=tailscale-debug.apk
@@ -109,21 +109,21 @@ release-tv: jarsign-env $(RELEASE_TV_AAB) ## Build the release AAB
109109
.PHONY: gradle-dependencies
110110
gradle-dependencies: $(shell find android -type f -not -path "android/build/*" -not -path '*/.*') $(LIBTAILSCALE) tailscale.version
111111

112-
$(DEBUG_APK): gradle-dependencies
112+
$(DEBUG_APK): version gradle-dependencies
113113
(cd android && ./gradlew test assembleDebug)
114114
install -C android/build/outputs/apk/debug/android-debug.apk $@
115115

116-
$(RELEASE_AAB): gradle-dependencies
116+
$(RELEASE_AAB): version gradle-dependencies
117117
@echo "Building release AAB"
118118
(cd android && ./gradlew test bundleRelease)
119119
install -C ./android/build/outputs/bundle/release/android-release.aab $@
120120

121-
$(RELEASE_TV_AAB): gradle-dependencies
121+
$(RELEASE_TV_AAB): version gradle-dependencies
122122
@echo "Building TV release AAB"
123123
(cd android && ./gradlew test bundleRelease_tv)
124124
install -C ./android/build/outputs/bundle/release_tv/android-release_tv.aab $@
125125

126-
tailscale-test.apk: gradle-dependencies
126+
tailscale-test.apk: version gradle-dependencies
127127
(cd android && ./gradlew assembleApplicationTestAndroidTest)
128128
install -C ./android/build/outputs/apk/androidTest/applicationTest/android-applicationTest-androidTest.apk $@
129129

0 commit comments

Comments
 (0)