Skip to content

Commit 0276231

Browse files
authored
Use the import * as React from 'react' pattern (#2242)
* use the `import * as React from 'react'` pattern We use named imports, but we have to import `React` itself as well for JSX because it compiles to `React.createElement`. We could get rid of our own JSX and use it directly, or we can use this `import * as React from 'react'` syntax. This fixes an issue for people using `allowSyntheticDefaultImports: false` in TypeScript. Fixes: #2117 * update changelog
1 parent 551261a commit 0276231

File tree

22 files changed

+40
-21
lines changed

22 files changed

+40
-21
lines changed

packages/@headlessui-react/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212
- Fix SSR tab hydration when using Strict Mode in development ([#2231](https://github.com/tailwindlabs/headlessui/pull/2231))
1313
- Don't break overflow when multiple dialogs are open at the same time ([#2215](https://github.com/tailwindlabs/headlessui/pull/2215))
1414
- Fix "This `Suspense` boundary received an update before it finished hydrating" error in the `Disclosure` component ([#2238](https://github.com/tailwindlabs/headlessui/pull/2238))
15+
- Use the `import * as React from 'react'` pattern ([#2242](https://github.com/tailwindlabs/headlessui/pull/2242))
1516

1617
## [1.7.8] - 2023-01-27
1718

packages/@headlessui-react/src/components/combobox/combobox.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import React, {
1+
import * as React from 'react'
2+
import {
23
Fragment,
34
createContext,
45
createRef,

packages/@headlessui-react/src/components/description/description.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import React, {
1+
import * as React from 'react'
2+
import {
23
createContext,
34
useContext,
45
useMemo,

packages/@headlessui-react/src/components/dialog/dialog.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// WAI-ARIA: https://www.w3.org/WAI/ARIA/apg/patterns/dialogmodal/
2-
import React, {
2+
import * as React from 'react'
3+
import {
34
createContext,
45
createRef,
56
useContext,

packages/@headlessui-react/src/components/disclosure/disclosure.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// WAI-ARIA: https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/
2-
import React, {
2+
import * as React from 'react'
3+
import {
34
Fragment,
45
createContext,
56
useContext,

packages/@headlessui-react/src/components/focus-trap/focus-trap.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import React, {
1+
import * as React from 'react'
2+
import {
23
useEffect,
34
useRef,
45

packages/@headlessui-react/src/components/label/label.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import React, {
1+
import * as React from 'react'
2+
import {
23
createContext,
34
useContext,
45
useMemo,

packages/@headlessui-react/src/components/listbox/listbox.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import React, {
1+
import * as React from 'react'
2+
import {
23
Fragment,
34
createContext,
45
createRef,

packages/@headlessui-react/src/components/menu/menu.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// WAI-ARIA: https://www.w3.org/WAI/ARIA/apg/patterns/menubutton/
2-
import React, {
2+
import * as React from 'react'
3+
import {
34
Fragment,
45
createContext,
56
createRef,

packages/@headlessui-react/src/components/popover/popover.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import React, {
1+
import * as React from 'react'
2+
import {
23
createContext,
34
createRef,
45
useContext,

0 commit comments

Comments
 (0)