Skip to content

Commit 46ee372

Browse files
temporarily disable details:not(:has(> summary))
We can re-enable it once we bump nswapi, jsdom and/or jest to vitest and verify that it works once those dependencies are bumped. Co-Authored-By: Jordan Pittman <[email protected]>
1 parent d3e0c3c commit 46ee372

File tree

6 files changed

+8
-6
lines changed

6 files changed

+8
-6
lines changed

packages/@headlessui-react/CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111

1212
- Ensure we are not freezing data when the `static` prop is used ([#3779](https://github.com/tailwindlabs/headlessui/pull/3779))
1313
- Ensure `onChange` types are contravariant instead of bivariant ([#3781](https://github.com/tailwindlabs/headlessui/pull/3781))
14-
- Support `<details>` as a focusable element without `<summary>` ([#3389](https://github.com/tailwindlabs/headlessui/pull/3389))
1514
- Support `<summary>` as a focusable element inside `<details>` ([#3389](https://github.com/tailwindlabs/headlessui/pull/3389))
1615

1716
## [2.2.7] - 2025-07-30

packages/@headlessui-react/src/test-utils/interactions.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,8 @@ let focusableSelector = [
489489
'iframe',
490490
'input:not([disabled])',
491491
'select:not([disabled])',
492-
'details:not(:has(> summary))',
492+
// TODO: Re-enable once we bump JSDOM
493+
// 'details:not(:has(> summary))',
493494
'details>summary',
494495
'textarea:not([disabled])',
495496
]

packages/@headlessui-react/src/utils/focus-management.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ export let focusableSelector = [
1515
'iframe',
1616
'input:not([disabled])',
1717
'select:not([disabled])',
18-
'details:not(:has(> summary))',
18+
// TODO: Re-enable once we bump JSDOM
19+
// 'details:not(:has(> summary))',
1920
'details>summary',
2021
'textarea:not([disabled])',
2122
]

packages/@headlessui-vue/CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1818
- Fix restoring focus to correct element when closing `Dialog` component ([#3365](https://github.com/tailwindlabs/headlessui/pull/3365))
1919
- Cleanup `process` in Combobox component when using virtualization ([#3495](https://github.com/tailwindlabs/headlessui/pull/3495))
2020
- Ensure outside click properly works when clicking SVG elements ([#3777](https://github.com/tailwindlabs/headlessui/pull/3777))
21-
- Support `<details>` as a focusable element without `<summary>` ([#3389](https://github.com/tailwindlabs/headlessui/pull/3389))
2221
- Support `<summary>` as a focusable element inside `<details>` ([#3389](https://github.com/tailwindlabs/headlessui/pull/3389))
2322

2423
## [1.7.22] - 2024-05-08

packages/@headlessui-vue/src/test-utils/interactions.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,8 @@ let focusableSelector = [
467467
'iframe',
468468
'input:not([disabled])',
469469
'select:not([disabled])',
470-
'details:not(:has(> summary))',
470+
// TODO: Re-enable once we bump JSDOM
471+
// 'details:not(:has(> summary))',
471472
'details>summary',
472473
'textarea:not([disabled])',
473474
]

packages/@headlessui-vue/src/utils/focus-management.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ export let focusableSelector = [
1313
'iframe',
1414
'input:not([disabled])',
1515
'select:not([disabled])',
16-
'details:not(:has(> summary))',
16+
// TODO: Re-enable once we bump JSDOM
17+
// 'details:not(:has(> summary))',
1718
'details>summary',
1819
'textarea:not([disabled])',
1920
]

0 commit comments

Comments
 (0)