Fix incorrect double invocation of menu items (#3766)

This PR fixes an issue where menu items would be invoked twice when you
click on an item.

This is due to a bug in the `useQuickRelease` hook where the timestamp
was not reset correctly, which means that the actual click caused a
quick release trigger. This in turn selects / invokes the menu item even
though it was already triggered by the click of the user.

This PR fixes that by resetting the timestamp as soon as possible, which
also cleans up the code a bit because there is only 1 branch where we
need to reset instead of in every branch before returning.

Fixes: #3763
Fixes: #3764
Fixes: #3765

Author: RobinMalfait

packages/@headlessui-react/CHANGELOG.md

@@ -7,7 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-- Nothing yet!
+### Fixed
+
+- Fix incorrect double invocation of menu items, listbox options and combobox options ([#3766](https://github.com/tailwindlabs/headlessui/pull/3766))
 
 ## [2.2.6] - 2025-07-24
 

packages/@headlessui-react/src/hooks/use-quick-release.ts

@@ -57,7 +57,7 @@ export function useQuickRelease(
 ) {
   // Capture the timestamp of when the `pointerdown` event happened on the
   // trigger.
-  let triggeredAtRef = useRef<Date | null>(null)
+  let triggeredAtRef = useRef<number | null>(null)
   let startXRef = useRef<number | null>(null)
   let startYRef = useRef<number | null>(null)
   useDocumentEvent(enabled && trigger !== null, 'pointerdown', (e) => {
@@ -67,14 +67,17 @@ export function useQuickRelease(
     startXRef.current = e.x
     startYRef.current = e.y
 
-    triggeredAtRef.current = new Date()
+    triggeredAtRef.current = e.timeStamp
   })
 
   useDocumentEvent(
     enabled && trigger !== null,
     'pointerup',
     (e) => {
-      if (triggeredAtRef.current === null) return
+      let triggeredAt = triggeredAtRef.current
+      if (triggeredAt === null) return
+      triggeredAtRef.current = null
+
       if (!DOM.isHTMLorSVGElement(e.target)) return
 
       // Ensure we moved the pointer a bit before considering it a quick
@@ -88,15 +91,12 @@ export function useQuickRelease(
 
       let result = action(e as PointerEventWithTarget)
 
-      let diffInMs = new Date().getTime() - triggeredAtRef.current.getTime()
-      triggeredAtRef.current = null
-
       switch (result.kind) {
         case ActionKind.Ignore:
           return
 
         case ActionKind.Select: {
-          if (diffInMs > POINTER_HOLD_THRESHOLD) {
+          if (e.timeStamp - triggeredAt > POINTER_HOLD_THRESHOLD) {
             select(result.target)
             close()
           }