cleanup unnecesary dependencies

Author: RobinMalfait

packages/@headlessui-react/src/components/disclosure/disclosure.tsx

@@ -179,19 +179,16 @@ let Button = forwardRefWithAs(function Button<TTag extends ElementType = typeof
     [dispatch]
   )
 
-  let handleKeyUp = useCallback(
-    (event: ReactKeyboardEvent<HTMLButtonElement>) => {
-      switch (event.key) {
-        case Keys.Space:
-          // Required for firefox, event.preventDefault() in handleKeyDown for
-          // the Space key doesn't cancel the handleKeyUp, which in turn
-          // triggers a *click*.
-          event.preventDefault()
-          break
-      }
-    },
-    [dispatch]
-  )
+  let handleKeyUp = useCallback((event: ReactKeyboardEvent<HTMLButtonElement>) => {
+    switch (event.key) {
+      case Keys.Space:
+        // Required for firefox, event.preventDefault() in handleKeyDown for
+        // the Space key doesn't cancel the handleKeyUp, which in turn
+        // triggers a *click*.
+        event.preventDefault()
+        break
+    }
+  }, [])
 
   let handleClick = useCallback(
     (event: ReactMouseEvent) => {

packages/@headlessui-react/src/components/listbox/listbox.tsx

@@ -307,19 +307,16 @@ let Button = forwardRefWithAs(function Button<TTag extends ElementType = typeof
     [dispatch, state, d]
   )
 
-  let handleKeyUp = useCallback(
-    (event: ReactKeyboardEvent<HTMLButtonElement>) => {
-      switch (event.key) {
-        case Keys.Space:
-          // Required for firefox, event.preventDefault() in handleKeyDown for
-          // the Space key doesn't cancel the handleKeyUp, which in turn
-          // triggers a *click*.
-          event.preventDefault()
-          break
-      }
-    },
-    [dispatch]
-  )
+  let handleKeyUp = useCallback((event: ReactKeyboardEvent<HTMLButtonElement>) => {
+    switch (event.key) {
+      case Keys.Space:
+        // Required for firefox, event.preventDefault() in handleKeyDown for
+        // the Space key doesn't cancel the handleKeyUp, which in turn
+        // triggers a *click*.
+        event.preventDefault()
+        break
+    }
+  }, [])
 
   let handleClick = useCallback(
     (event: ReactMouseEvent) => {

packages/@headlessui-react/src/components/menu/menu.tsx

@@ -251,19 +251,16 @@ let Button = forwardRefWithAs(function Button<TTag extends ElementType = typeof
     [dispatch, d]
   )
 
-  let handleKeyUp = useCallback(
-    (event: ReactKeyboardEvent<HTMLButtonElement>) => {
-      switch (event.key) {
-        case Keys.Space:
-          // Required for firefox, event.preventDefault() in handleKeyDown for
-          // the Space key doesn't cancel the handleKeyUp, which in turn
-          // triggers a *click*.
-          event.preventDefault()
-          break
-      }
-    },
-    [dispatch]
-  )
+  let handleKeyUp = useCallback((event: ReactKeyboardEvent<HTMLButtonElement>) => {
+    switch (event.key) {
+      case Keys.Space:
+        // Required for firefox, event.preventDefault() in handleKeyDown for
+        // the Space key doesn't cancel the handleKeyUp, which in turn
+        // triggers a *click*.
+        event.preventDefault()
+        break
+    }
+  }, [])
 
   let handleClick = useCallback(
     (event: ReactMouseEvent) => {
@@ -430,19 +427,16 @@ let Items = forwardRefWithAs(function Items<TTag extends ElementType = typeof DE
     [dispatch, searchDisposables, state]
   )
 
-  let handleKeyUp = useCallback(
-    (event: ReactKeyboardEvent<HTMLButtonElement>) => {
-      switch (event.key) {
-        case Keys.Space:
-          // Required for firefox, event.preventDefault() in handleKeyDown for
-          // the Space key doesn't cancel the handleKeyUp, which in turn
-          // triggers a *click*.
-          event.preventDefault()
-          break
-      }
-    },
-    [dispatch]
-  )
+  let handleKeyUp = useCallback((event: ReactKeyboardEvent<HTMLButtonElement>) => {
+    switch (event.key) {
+      case Keys.Space:
+        // Required for firefox, event.preventDefault() in handleKeyDown for
+        // the Space key doesn't cancel the handleKeyUp, which in turn
+        // triggers a *click*.
+        event.preventDefault()
+        break
+    }
+  }, [])
 
   let slot = useMemo<ItemsRenderPropArg>(() => ({ open: state.menuState === MenuStates.Open }), [
     state,

packages/@headlessui-vue/src/utils/render.test.ts

@@ -1,4 +1,4 @@
-import { defineComponent, h } from 'vue'
+import { defineComponent } from 'vue'
 import { render as testRender } from '../test-utils/vue-testing-library'
 
 import { render } from './render'