Commit 23a03cb
authored
Cancel initial file search if it takes too long (#1242)
Fixes #986 (hopefully)
There's a lot of detail about the problem in the linked issue and my
response at the bottom. But briefly:
- Searches can take way too long; even spinning "forever" for some
people
- This occurs more often if following symlinks is enabled in VSCode
- We can cancel in-flight searches
This PR starts the searches and cancels them after ~15s. If the
extension hasn't found anything within 15s then it's likely it'll take
~15s any time you open that project and that would've been an absolutely
horrible dev experience that we probably would've been notified about.
It seems reasonable to set a time limit on the search do determine if we
need to start a language server1 parent c8efeca commit 23a03cb
2 files changed
+32
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
581 | 583 | | |
582 | 584 | | |
583 | 585 | | |
584 | | - | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
585 | 600 | | |
586 | 601 | | |
587 | 602 | | |
| 603 | + | |
| 604 | + | |
588 | 605 | | |
589 | 606 | | |
590 | 607 | | |
591 | 608 | | |
592 | 609 | | |
| 610 | + | |
593 | 611 | | |
594 | 612 | | |
595 | | - | |
| 613 | + | |
596 | 614 | | |
597 | 615 | | |
598 | 616 | | |
599 | 617 | | |
600 | 618 | | |
601 | 619 | | |
602 | 620 | | |
603 | | - | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
604 | 625 | | |
605 | 626 | | |
606 | 627 | | |
| |||
616 | 637 | | |
617 | 638 | | |
618 | 639 | | |
| 640 | + | |
619 | 641 | | |
620 | 642 | | |
621 | 643 | | |
622 | 644 | | |
623 | 645 | | |
624 | 646 | | |
625 | | - | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
626 | 653 | | |
627 | 654 | | |
628 | 655 | | |
| |||
0 commit comments