Skip to content

Commit bcfb38d

Browse files
Refactor length function to utilize a pre-compiled RegExp (#12251)
* Refactor length function to utilize a pre-compiled RegExp * Update dataTypes.js
1 parent 4e1a26a commit bcfb38d

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/util/dataTypes.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,9 @@ let lengthUnits = [
173173
'cqmax',
174174
]
175175
let lengthUnitsPattern = `(?:${lengthUnits.join('|')})`
176+
let lengthRegExp = new RegExp(`^[+-]?[0-9]*\.?[0-9]+(?:[eE][+-]?[0-9]+)?${lengthUnitsPattern}$`)
176177
export function length(value) {
177-
return (
178-
value === '0' ||
179-
new RegExp(`^[+-]?[0-9]*\.?[0-9]+(?:[eE][+-]?[0-9]+)?${lengthUnitsPattern}$`).test(value) ||
180-
isCSSFunction(value)
181-
)
178+
return value === '0' || lengthRegExp.test(value) || isCSSFunction(value)
182179
}
183180

184181
let lineWidths = new Set(['thin', 'medium', 'thick'])

0 commit comments

Comments
 (0)