fix: check row exists during updates

Author: mlipscombe

__tests__/integration/__snapshots__/update.test.js.snap

@@ -776,6 +776,94 @@ GraphQLSchema {
 }
 `;
 
+exports[`update with no row matched works 1`] = `
+GraphQLSchema {
+  "__allowedLegacyNames": Array [],
+  "__validationErrors": undefined,
+  "_directives": Array [
+    "@include",
+    "@skip",
+    "@deprecated",
+  ],
+  "_implementations": Object {
+    "Node": Array [
+      "Query",
+      "Child",
+      "Parent",
+    ],
+  },
+  "_mutationType": "Mutation",
+  "_possibleTypeMap": undefined,
+  "_queryType": "Query",
+  "_subscriptionType": undefined,
+  "_typeMap": Object {
+    "Boolean": "Boolean",
+    "Child": "Child",
+    "ChildChildPkeyConnect": "ChildChildPkeyConnect",
+    "ChildCondition": "ChildCondition",
+    "ChildInput": "ChildInput",
+    "ChildNodeIdConnect": "ChildNodeIdConnect",
+    "ChildOnChildForChildParentFkeyNodeIdUpdate": "ChildOnChildForChildParentFkeyNodeIdUpdate",
+    "ChildOnChildForChildParentFkeyUsingChildPkeyUpdate": "ChildOnChildForChildParentFkeyUsingChildPkeyUpdate",
+    "ChildParentFkeyChildCreateInput": "ChildParentFkeyChildCreateInput",
+    "ChildParentFkeyInput": "ChildParentFkeyInput",
+    "ChildParentFkeyInverseInput": "ChildParentFkeyInverseInput",
+    "ChildParentFkeyParentCreateInput": "ChildParentFkeyParentCreateInput",
+    "ChildPatch": "ChildPatch",
+    "ChildrenConnection": "ChildrenConnection",
+    "ChildrenEdge": "ChildrenEdge",
+    "ChildrenOrderBy": "ChildrenOrderBy",
+    "CreateChildInput": "CreateChildInput",
+    "CreateChildPayload": "CreateChildPayload",
+    "CreateParentInput": "CreateParentInput",
+    "CreateParentPayload": "CreateParentPayload",
+    "Cursor": "Cursor",
+    "DeleteChildByIdInput": "DeleteChildByIdInput",
+    "DeleteChildInput": "DeleteChildInput",
+    "DeleteChildPayload": "DeleteChildPayload",
+    "DeleteParentByIdInput": "DeleteParentByIdInput",
+    "DeleteParentInput": "DeleteParentInput",
+    "DeleteParentPayload": "DeleteParentPayload",
+    "ID": "ID",
+    "Int": "Int",
+    "Mutation": "Mutation",
+    "Node": "Node",
+    "PageInfo": "PageInfo",
+    "Parent": "Parent",
+    "ParentCondition": "ParentCondition",
+    "ParentInput": "ParentInput",
+    "ParentNodeIdConnect": "ParentNodeIdConnect",
+    "ParentOnChildForChildParentFkeyNodeIdUpdate": "ParentOnChildForChildParentFkeyNodeIdUpdate",
+    "ParentOnChildForChildParentFkeyUsingParentPkeyUpdate": "ParentOnChildForChildParentFkeyUsingParentPkeyUpdate",
+    "ParentParentPkeyConnect": "ParentParentPkeyConnect",
+    "ParentPatch": "ParentPatch",
+    "ParentsConnection": "ParentsConnection",
+    "ParentsEdge": "ParentsEdge",
+    "ParentsOrderBy": "ParentsOrderBy",
+    "Query": "Query",
+    "String": "String",
+    "UpdateChildByIdInput": "UpdateChildByIdInput",
+    "UpdateChildInput": "UpdateChildInput",
+    "UpdateChildPayload": "UpdateChildPayload",
+    "UpdateParentByIdInput": "UpdateParentByIdInput",
+    "UpdateParentInput": "UpdateParentInput",
+    "UpdateParentPayload": "UpdateParentPayload",
+    "__Directive": "__Directive",
+    "__DirectiveLocation": "__DirectiveLocation",
+    "__EnumValue": "__EnumValue",
+    "__Field": "__Field",
+    "__InputValue": "__InputValue",
+    "__Schema": "__Schema",
+    "__Type": "__Type",
+    "__TypeKind": "__TypeKind",
+    "updateChildOnChildForChildParentFkeyPatch": "updateChildOnChildForChildParentFkeyPatch",
+    "updateParentOnChildForChildParentFkeyPatch": "updateParentOnChildForChildParentFkeyPatch",
+  },
+  "astNode": undefined,
+  "extensionASTNodes": undefined,
+}
+`;
+
 exports[`updateByNodeId does not error 1`] = `
 GraphQLSchema {
   "__allowedLegacyNames": Array [],

__tests__/integration/update.test.js

@@ -736,3 +736,49 @@ test(
     },
   }),
 );
+
+test(
+  'update with no row matched works',
+  withSchema({
+    setup: `
+      create table p.parent (
+        id serial primary key,
+        name text not null
+      );
+
+      create table p.child (
+        id serial primary key,
+        parent_id integer,
+        name text not null,
+        constraint child_parent_fkey foreign key (parent_id)
+          references p.parent (id)
+      );
+
+      insert into p.parent values(1, 'test parent');
+      insert into p.child values(1, 1, 'test child');
+    `,
+    test: async ({ schema, pgClient }) => {
+      const query = `
+        mutation {
+          updateParentById(
+            input: {
+              id: 2
+              parentPatch: {
+                name: "other name"
+              }
+            }
+          ) {
+            parent {
+              id
+              name
+            }
+          }
+        }
+      `;
+      expect(schema).toMatchSnapshot();
+
+      const result = await graphql(schema, query, null, { pgClient });
+      expect(result).not.toHaveProperty('errors');
+    },
+  }),
+);

src/PostgraphileNestedMutationsPlugin.js

@@ -565,7 +565,7 @@ module.exports = function PostGraphileNestedMutationPlugin(builder) {
         const primaryKeyConstraint = table.constraints.find(
           (con) => con.type === 'p',
         );
-        if (primaryKeyConstraint) {
+        if (primaryKeyConstraint && row) {
           const primaryKeyFields = primaryKeyConstraint.keyAttributes;
 
           const where = [];