-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
📚 CHANGELOGDocumenting changes between releasesDocumenting changes between releases📋 Roody NotesFrom @roodyyogurt annotated PDF of Hugo BookFrom @roodyyogurt annotated PDF of Hugo Book🕑 pending approvalIssue requires approval by Ken TessmanIssue requires approval by Ken Tessman🕑 pending decisionIssue requires decisions by maintainersIssue requires decisions by maintainers💀 bugSomething isn't workingSomething isn't working💀 text problemsText problems, typos or obsolete contents.Text problems, typos or obsolete contents.⚠️ importantPriority: HighPriority: High
Milestone
Description
- Fix document source (see below).
- Document the changes in
CHANGES.md. - Document in ChangeLog.
- Get @tessman approval for these changes.
- Updated commented notes in source files.
In his annotated PDF, @roodyyogurt pointed some discrepancies between the tokens names or values found §15.1. Tokens and those found in Appendix H: Code Patterns:
| §15.1 | App. H | htokens.h |
|---|---|---|
$47 textdata# |
$47 text# |
$47 textdata# |
$49 label# |
$49 debugdata# |
$49 debugdata# |
$75 colour |
$74 colour |
$74 colour |
$76 picture |
$75 picture |
$75 picture |
$76 picture |
$76 label# |
$76 label# |
$7A addcontext |
(missing) | $7A addcontext |
$7B video |
(missing) | $7B video |
The correct list of Hugo token names (and associated values) can be found in the htokens.h header from the Hugo sources repository (as indicated in the third column of the above table).
- Resolve all discrepancies in the tokens names and values by referring to the definition in
htokens.h:- In §15.1. Tokens:
- fix tokens table (commit ee29947):
- $49
label#→ $49debugdata#. - $75
colour→ $74colour. - $76
picture→ $75picture. - add → $76
label#. - Document fixes in
CHANGES.md.
- $49
- fix tokens table (commit ee29947):
- In Appendix H: Code Patterns.
- fix tokens names (commit ee29947):
- $47
text#→ $47textdata#. - Document fixes in
CHANGES.md.
- $47
- Add missing tokens (moved to Issue App. H: Tokens $7A and $7B Missing #73):
- $7A
addcontext - $7B
video
- $7A
- fix tokens names (commit ee29947):
- In §15.1. Tokens:
- Check if the amended tokens names/values also occur in other places of the book:
- None found by searching for the tokens by names.
- Check hex values in binary examples:
- couldn't find any.
NOTE — Addition of the missing tokens (
addcontextandvideo) to App. H has been moved to a separate Issue (#73) because it involves adding new contents, and might therefore require a separate discussion.
Reference Links
- Hugo Book live previews:
- §15.1. Tokens:
- original document
- fixed document (on
devbranch)
- App. H: Code Patterns:
- original document
- fixed document (on
devbranch)
- §15.1. Tokens:
- Hugo source code:
htokens.h— tokens definitions.
Reactions are currently unavailable
Metadata
Metadata
Labels
📚 CHANGELOGDocumenting changes between releasesDocumenting changes between releases📋 Roody NotesFrom @roodyyogurt annotated PDF of Hugo BookFrom @roodyyogurt annotated PDF of Hugo Book🕑 pending approvalIssue requires approval by Ken TessmanIssue requires approval by Ken Tessman🕑 pending decisionIssue requires decisions by maintainersIssue requires decisions by maintainers💀 bugSomething isn't workingSomething isn't working💀 text problemsText problems, typos or obsolete contents.Text problems, typos or obsolete contents.⚠️ importantPriority: HighPriority: High