Skip to content

Commit b5c3af2

Browse files
chore: update TCA to version 1.22.3 and align with SwiftSyntax 603 support (#233)
* fix: re-enable LockmanResult tests with updated API compatibility ## Summary - Re-enabled LockmanResultTests.swift by updating for new LockmanResult API - Fixed all test methods to work with unlockToken parameters - Removed .disabled extension from test file ## Changes Made ### API Compatibility Updates - Updated all LockmanResult case usage to include unlockToken parameters: - .success(unlockToken: token) - .successWithPrecedingCancellation(unlockToken: token, error: error) - .cancel(error) remains unchanged - Replaced mock strategy with TestSingleExecutionStrategy from TestSupport - Fixed TestLockmanInfo constructor calls with proper parameter order ### Test Coverage Maintained - All 13 comprehensive test methods updated and working - Phase 1: Basic enum case testing with unlockToken - Phase 2: Sendable conformance and concurrent access testing - Phase 3: Error protocol integration testing - Phase 4: unlockToken functionality and type safety testing ### Technical Fixes - Removed fileprivate property access (LockmanUnlock.info) - Fixed strategy ID references to use TestSingleExecutionStrategy - Updated all TestLockmanInfo instantiations with correct parameters - Ensured all pattern matching works with new API structure ## Test Results - ✅ All 13 tests pass (Executed 13 tests, with 0 failures) - ✅ Complete API compatibility with unlockToken integration - ✅ Comprehensive coverage of LockmanResult enum functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * chore: update TCA to version 1.22.3 and improve file path consistency - Update swift-composable-architecture from 1.22.2 to 1.22.3 - Update both Package.swift and [email protected] for consistency - Replace #file with #filePath in issue reporting for consistency with TCA 1.22.3 - Fix LockmanComposableIssueReporter to use #fileID for proper TCA integration 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * chore: update SwiftSyntax version range to support 603.0.0 Update SwiftSyntax dependency from "509.0.0"..<"602.0.0" to "509.0.0"..<"603.0.0" to align with TCA 1.22.3 requirements (swift-composable-architecture PR #3776). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
1 parent 7771953 commit b5c3af2

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

Package.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ let package = Package(
1919
targets: ["Lockman"])
2020
],
2121
dependencies: [
22-
.package(url: "https://github.com/pointfreeco/swift-composable-architecture", exact: "1.22.2"),
23-
.package(url: "https://github.com/swiftlang/swift-syntax", "509.0.0"..<"602.0.0"),
22+
.package(url: "https://github.com/pointfreeco/swift-composable-architecture", exact: "1.22.3"),
23+
.package(url: "https://github.com/swiftlang/swift-syntax", "509.0.0"..<"603.0.0"),
2424
.package(url: "https://github.com/pointfreeco/swift-macro-testing", from: "0.6.3"),
2525
.package(url: "https://github.com/apple/swift-collections.git", from: "1.1.0"),
2626
.package(url: "https://github.com/swiftlang/swift-docc-plugin", from: "1.4.5"),

[email protected]

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ let package = Package(
1919
targets: ["Lockman"])
2020
],
2121
dependencies: [
22-
.package(url: "https://github.com/pointfreeco/swift-composable-architecture", exact: "1.22.2"),
23-
.package(url: "https://github.com/swiftlang/swift-syntax", "509.0.0"..<"602.0.0"),
22+
.package(url: "https://github.com/pointfreeco/swift-composable-architecture", exact: "1.22.3"),
23+
.package(url: "https://github.com/swiftlang/swift-syntax", "509.0.0"..<"603.0.0"),
2424
.package(url: "https://github.com/pointfreeco/swift-macro-testing", from: "0.6.3"),
2525
.package(url: "https://github.com/apple/swift-collections.git", from: "1.1.0"),
2626
.package(url: "https://github.com/swiftlang/swift-docc-plugin", from: "1.4.5"),

Sources/Lockman/Composable/LockmanComposableIssueReporter.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import ComposableArchitecture
44
public enum LockmanComposableIssueReporter: LockmanIssueReporter {
55
public static func reportIssue(
66
_ message: String,
7-
file: StaticString = #file,
7+
file: StaticString = #fileID,
88
line: UInt = #line
99
) {
1010
IssueReporting.reportIssue(message, fileID: file, line: line)

Sources/Lockman/Core/Protocols/LockmanIssueReporter.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public protocol LockmanIssueReporter {
2222
public enum LockmanDefaultIssueReporter: LockmanIssueReporter {
2323
public static func reportIssue(
2424
_ message: String,
25-
file: StaticString = #file,
25+
file: StaticString = #filePath,
2626
line: UInt = #line
2727
) {
2828
#if DEBUG
@@ -49,7 +49,7 @@ public enum LockmanIssueReporting {
4949
/// Reports an issue using the configured reporter.
5050
public static func reportIssue(
5151
_ message: String,
52-
file: StaticString = #file,
52+
file: StaticString = #filePath,
5353
line: UInt = #line
5454
) {
5555
reporter.reportIssue(message, file: file, line: line)

0 commit comments

Comments
 (0)