fix(clash_of_code): add defaults to api data

allows more failsafes and less exposed to minor api changes

Author: takos22

codingame/clash_of_code/clash_of_code.py

@@ -125,21 +125,26 @@ def _set_data(self, data: ClashOfCodeDict):
         )
 
         self._setattr("public", data.get("type", "PUBLIC") == "PUBLIC")
-        self._setattr("min_players", data["nbPlayersMin"])
-        self._setattr("max_players", data["nbPlayersMax"])
+        self._setattr("min_players", data.get("nbPlayersMin", 2))
+        self._setattr("max_players", data.get("nbPlayersMax", 100))
         self._setattr("modes", data.get("modes"))
         self._setattr("programming_languages", data.get("programmingLanguages"))
 
-        self._setattr("started", data["started"])
-        self._setattr("finished", data["finished"])
+        self._setattr("started", data.get("started"))
+        self._setattr("finished", data.get("finished"))
         self._setattr("mode", data.get("mode"))
 
         self._setattr("creation_time", to_datetime(data.get("creationTime")))
         self._setattr("start_time", to_datetime(data.get("startTimestamp")))
         self._setattr("end_time", to_datetime(data.get("endTime")))
 
         self._setattr(
-            "time_before_start", timedelta(milliseconds=data["msBeforeStart"])
+            "time_before_start",
+            (
+                timedelta(milliseconds=data["msBeforeStart"])
+                if "msBeforeStart" in data
+                else None
+            ),
         )
         self._setattr(
             "time_before_end",
@@ -160,9 +165,13 @@ def _set_data(self, data: ClashOfCodeDict):
                     self.finished,
                     player,
                 )
-                for player in data.get("players", [])
-            ]
-            or minified_players_to_players(data.get("minifiedPlayers", [])),
+                for player in data.get(
+                    "players",
+                    minified_players_to_players(
+                        data.get("minifiedPlayers", [])
+                    ),
+                )
+            ],
         )
 
     def __repr__(self) -> str:

codingame/clash_of_code/player.py

@@ -137,7 +137,7 @@ def __init__(
         self.started = started
         self.finished = finished
 
-        self.status = data["status"]
+        self.status = data.get("status", "STANDARD")
         self.owner = self.status == "OWNER"
         self.position = data.get("position")
         self.rank = data.get("rank")

codingame/clash_of_code/question.py

@@ -20,10 +20,10 @@ class TestCase(BaseObject):
     output_binary_id: int
 
     def __init__(self, state: "ConnectionState", data: TestCaseDict):
-        self.index = data["index"]
+        self.index = data.get("index")
         self.label = data.get("label")
-        self.input_binary_id = data["inputBinaryId"]
-        self.output_binary_id = data["outputBinaryId"]
+        self.input_binary_id = data.get("inputBinaryId")
+        self.output_binary_id = data.get("outputBinaryId")
 
         super().__init__(state)
 
@@ -66,14 +66,11 @@ def __init__(
     ):
         self.clash_of_code = clash_of_code
         self.test_case = test_case
-        self.success = data["comparison"]["success"]
-        self.found = (
-            data["comparison"]["found"]
-            if "found" in data["comparison"]
-            else data["output"]
-        )
+        comparison = data.get("comparison", {})
+        self.success = comparison.get("success")
+        self.found = comparison.get("found", data.get("output"))
         self.expected = (
-            data["output"] if self.success else data["comparison"]["expected"]
+            data.get("output") if self.success else comparison.get("expected")
         )
 
         super().__init__(state)
@@ -91,14 +88,12 @@ def __init__(
         contributor: Optional[PartialCodinGamer],
         data: ContributionDict,
     ):
-        self.type = data["type"]
-        self.status = data["status"]
+        self.type = data.get("type")
+        self.status = data.get("status")
         self.contributor = contributor
-        self.moderators = (
-            [PartialCodinGamer(state, mod) for mod in data["moderators"]]
-            if "moderators" in data
-            else []
-        )
+        self.moderators = [
+            PartialCodinGamer(state, mod) for mod in data.get("moderators", [])
+        ]
 
         super().__init__(state)
 
@@ -125,19 +120,19 @@ def __init__(
     ):
         self.clash_of_code = clash_of_code
         self.id = data["id"]
-        self.initial_id = data["initialId"]
-        self.type = data["type"]
-        self.mode = data["mode"]
-        self.raw_statement = data["statement"]
-        self.stub_generator = data["stubGenerator"]
-        self.duration = data["duration"]
-        self.index = data["index"]
+        self.initial_id = data.get("initialId")
+        self.type = data.get("type")
+        self.mode = data.get("mode")
+        self.raw_statement = data.get("statement")
+        self.stub_generator = data.get("stubGenerator")
+        self.duration = data.get("duration")
+        self.index = data.get("index")
         self.test_cases = sorted(
-            [TestCase(state, case) for case in data["testCases"]],
+            [TestCase(state, case) for case in data.get("testCases", [])],
             key=lambda t: t.index,
         )
         self.available_language_ids = [
-            lang["id"] for lang in data["availableLanguages"]
+            lang["id"] for lang in data.get("availableLanguages", [])
         ]
         contributor = (
             PartialCodinGamer(state, data["contributor"])

codingame/clash_of_code/solution.py

@@ -49,14 +49,14 @@ def __init__(
             ),
         )
 
-        self.submission_id = data["testSessionQuestionSubmissionId"]
-        self.commentable_id = data["commentableId"]
-        self.votable_id = data["votableId"]
+        self.submission_id = data.get("testSessionQuestionSubmissionId")
+        self.commentable_id = data.get("commentableId")
+        self.votable_id = data.get("votableId")
 
-        self.creation_time = to_datetime(data["creationTime"])
-        self.language_id = data["programmingLanguageId"]
-        self.code = data["code"]
-        self.shared = data["shared"]
+        self.creation_time = to_datetime(data.get("creationTime"))
+        self.language_id = data.get("programmingLanguageId")
+        self.code = data.get("code")
+        self.shared = data.get("shared")
 
         super().__init__(state)